Repository navigation
feat: add deriveElectrumWallet to chain classes - #280
Conversation
|
1 finding · reviewed 🟠
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1528e70e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Closes #278
This adds
deriveElectrumWalletto the chain classes and puts the BIP32 glue that handed Decred a key anyway out of a job. It takes the seed, not the phrase, so a BIP322 verifier doesn't haul Electrum's old word list along.