Skip to content

feat: recover EVM transaction signers - #353

Merged
oritwoen merged 4 commits into
mainfrom
feat/evm-transaction-signer
Oct 29, 2026
Merged

oritwoen merged 4 commits into
mainfrom
feat/evm-transaction-signer

Conversation

@aeitwoen

@aeitwoen aeitwoen commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #270

This PR adds keys_transaction_signer_recover, pulling the public key and address out of a signed EVM transaction. Turns out every sender's public key was hiding in the signature all along.


Play the walkthrough    Follow each request

@aeitwoen aeitwoen self-assigned this Oct 29, 2026
@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 29, 2026 01:10
@coldtea-pr-lens

coldtea-pr-lens Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
  • Redraw · drawn at 777b548, the branch has moved on

Architecture

Architecture diagram for agntn/keys at 777b548

Play the walkthrough

Inside the changed components — 1 view

Component view — EVM Transaction Recovery

Internal modules and dependencies powering EVM transaction parsing and signer recovery.

Architecture view of Component view — EVM Transaction Recovery in agntn/keys

Data flow

Data flow diagram for agntn/keys at 777b548

Follow each request


Review

1 finding addressed · reviewed 777b548

Tip

Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
  • Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-29T01:34:30.469409Z 5eabc54 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/tool-operations/transaction.ts Resolved
@oritwoen
oritwoen merged commit e77bba2 into main Oct 29, 2026
2 checks passed
@oritwoen
oritwoen deleted the feat/evm-transaction-signer branch October 29, 2026 10:25
@github-actions github-actions Bot mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recover the signer of a signed EVM transaction

2 participants