Skip to content

Add example for synthetic tree evolution - #60

Merged
gkirgizov merged 28 commits into
mainfrom
tree-search-example
Mar 29, 2023
Merged

Add example for synthetic tree evolution#60
gkirgizov merged 28 commits into
mainfrom
tree-search-example

Conversation

@gkirgizov

@gkirgizov gkirgizov commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Refactor experiment setup for synthetic search
  • Add new dependency for fast Edit Distance computation on zss package
  • Implement new example

Closes #38

UPD: provides temporary fix for #63

@codecov-commenter

codecov-commenter commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #60 (3a193f9) into main (552e737) will decrease coverage by 8.46%.
The diff coverage is 67.25%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   73.54%   65.09%   -8.46%     
==========================================
  Files          97      114      +17     
  Lines        5330     6208     +878     
==========================================
+ Hits         3920     4041     +121     
- Misses       1410     2167     +757
Impacted Files Coverage Δ
golem/core/adapter/nx_adapter.py 97.72% <ø> (+24.39%) ⬆️
golem/core/optimisers/objective/objective.py 86.27% <ø> (ø)
golem/metrics/edit_distance.py 0.00% <0.00%> (ø)
golem/metrics/graph_metrics.py 0.00% <0.00%> (ø)
golem/core/dag/verification_rules.py 97.56% <50.00%> (-2.44%) ⬇️
golem/core/dag/linked_graph_node.py 97.67% <85.71%> (+2.21%) ⬆️
golem/core/optimisers/genetic/gp_optimizer.py 97.64% <87.50%> (+1.99%) ⬆️
...ore/optimisers/genetic/operators/base_mutations.py 90.10% <90.10%> (ø)
golem/core/dag/graph_utils.py 94.73% <100.00%> (ø)
golem/core/dag/linked_graph.py 100.00% <100.00%> (ø)
... and 4 more

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YamLyubov
YamLyubov self-requested a review March 6, 2023 09:44
@nicl-nno
nicl-nno requested a review from ABerezin15 March 6, 2023 10:15
nicl-nno
nicl-nno reviewed Mar 10, 2023
View reviewed changes
Comment thread examples/synthetic_graph_evolution/experiment.py
@nicl-nno

nicl-nno commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

image

Запустил пример tree_search - не очень понятно, какой тут нужно сделать вывод и что значит цвет узлов. Мб пояснить в описании примера или print-ах.

YamLyubov
YamLyubov reviewed Mar 16, 2023
View reviewed changes
Comment thread examples/synthetic_graph_evolution/utils.py Outdated
Comment thread examples/synthetic_graph_evolution/tree_search.py Outdated
Comment thread examples/synthetic_graph_evolution/graph_search.py
@gkirgizov

gkirgizov commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator Author

Запустил пример tree_search - не очень понятно, какой тут нужно сделать вывод и что значит цвет узлов. Мб пояснить в описании примера или print-ах.

Добавил легенду и заголовки на графики и описание эксперимента в докстринг скрипта. Сейчас маленькие графы оптимизатор успешно и точно находит (N<20). А вот с графами больше оптимизатор затыкается в локальных минимумах. Сейчас с этим разбираюсь и затем залью фиксы в отдельных PR.

@gkirgizov
gkirgizov requested review from YamLyubov and nicl-nno March 23, 2023 06:22
@gkirgizov gkirgizov mentioned this pull request Mar 23, 2023
Open
1 task
@nicl-nno

nicl-nno commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Сейчас маленькие графы оптимизатор успешно и точно находит (N<20)

Может тогда добавить такую (или хотя бы чуть смягченную) проверку в интеграционный тест?

YamLyubov
YamLyubov reviewed Mar 23, 2023
View reviewed changes
Comment thread golem/metrics/graph_metrics.py Outdated
@gkirgizov
gkirgizov merged commit b4c7848 into main Mar 29, 2023
@gkirgizov
gkirgizov deleted the tree-search-example branch March 29, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicl-nno nicl-nno nicl-nno approved these changes
@YamLyubov YamLyubov YamLyubov approved these changes
@ABerezin15 ABerezin15 Awaiting requested review from ABerezin15

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add example of Tree search with Edit Distance metric

4 participants

@gkirgizov @codecov-commenter @nicl-nno @YamLyubov