Skip to content

Fix timeout-related issues in tuners - #281

Merged
VadimsAhmers merged 6 commits into
mainfrom
fix_issue_280
Mar 24, 2025
Merged

Fix timeout-related issues in tuners #281
VadimsAhmers merged 6 commits into
mainfrom
fix_issue_280

Conversation

@VadimsAhmers

@VadimsAhmers VadimsAhmers commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Additionally:

Context

Closes #186, #267, #280

@VadimsAhmers

VadimsAhmers commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Я еще посмотрю, возможно похожие проблемы имеется и в других тюнерах (как минимум в IOptTuner небольшой timeout вызывает ошибку)

@nicl-nno
nicl-nno requested a review from Lopa10ko February 21, 2025 14:59
Lopa10ko
Lopa10ko reviewed Feb 21, 2025
View reviewed changes
Comment thread golem/core/tuning/sequential.py Outdated
@codecov-commenter

codecov-commenter commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.26%. Comparing base (b92b61f) to head (5afc7ac).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
golem/metrics/edit_distance.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   72.44%   71.26%   -1.19%     
==========================================
  Files         140      140              
  Lines        8421     8433      +12     
==========================================
- Hits         6101     6010      -91     
- Misses       2320     2423     +103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VadimsAhmers VadimsAhmers mentioned this pull request Mar 9, 2025
Closed
@VadimsAhmers

VadimsAhmers commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Я еще посмотрю, возможно похожие проблемы имеются и в других тюнерах (как минимум в IOptTuner небольшой timeout вызывает ошибку)

IOptTuner выдает ошибку если передавать в него timeout <=30 секунд, т.к. этот параметр передается в iOpt.Solver как timeout=0 (в минутах) из-за округления

@nicl-nno

nicl-nno commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

Ну пока можно округлять вверх на нашей стороне, а так видимо стоит issue создать им.

This was linked to issues Mar 16, 2025
GOLEM lib dependency on examples/ #267
Closed
[Bug]: UnboundLocalError: local variable 'final_graph' referenced before assignment on tuner timeout #280
Closed
nicl-nno
nicl-nno reviewed Mar 17, 2025
View reviewed changes
Comment thread golem/core/tuning/iopt_tuner.py
Lopa10ko
Lopa10ko reviewed Mar 17, 2025
View reviewed changes
Comment thread golem/core/tuning/sequential.py Outdated
Comment thread golem/core/tuning/sequential.py
@VadimsAhmers
VadimsAhmers merged commit 8812d51 into main Mar 24, 2025
@VadimsAhmers
VadimsAhmers deleted the fix_issue_280 branch March 24, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicl-nno nicl-nno nicl-nno approved these changes
@Lopa10ko Lopa10ko Lopa10ko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@VadimsAhmers @codecov-commenter @nicl-nno @Lopa10ko