Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mermaid HTML labels could request remote images during layout, before the final SVG sanitizer or Markdown media controls ran. Desktop could also reuse an authenticated file-mode backend despite requiring OS credential storage.
Apply an immutable pre-layout label allowlist and protect resource-bearing Mermaid configuration. Keep ordinary diagrams, formatting and safe MathML semantics; image-shaped nodes retain their explicit refusal. Desktop now requires the live authenticated owner proof to confirm OS storage before both early reuse and startup polling, with an explicit startup error for file, missing or invalid modes. Existing servers and credentials remain untouched.
Validation
PresentedAgentMarkdowncontrolled-network tests, streaming and separately activated Markdown media: passed. The browser suite passed 17 tests, including direct production-runtime MathML semantics/layout controls. Initial fixture-build timeout under concurrent load was resolved by a temporary startup-timeout increase; application code and assertions were unchanged.node scripts/ci/module-test-impact.mjs affected --base 94158f30c7fb35e8baa18d13dc1f7dbe7bb52436 --head f3141274cded0748d6438acb683f10c137a29391 -- --maxWorkers=4passed with exit 0: 1,066 files / 24,821 tests passed; 56 files / 3,321 tests skipped. It selected the desktop composition and renderer Streamdown modules plus registered consumers.Independent security reviews identified additional image-fetch paths and a MathML compatibility regression; both were fixed and the final review found no actionable blockers. No task-specific evidence reports are committed.
Scope and limits
Browser execution used real Chromium on macOS. Packaged Electron and real Linux/Windows credential-vault end-to-end checks are not claimed. MathML controls use the production runtime directly because the existing Markdown normalizer collapses
$$replacement tokens; that separate behavior is unchanged. Security negative tests use the actual Markdown surface.Formal security/runtime documentation describes the resulting behavior. Documentation-only PR #3498 edits the same paragraphs; integrate its other corrections while retaining this PR's final media and credential-mode policy. The separately checked local integration resolves that overlap; this branch keeps its scoped diff. Documentation corrections and UI consistency work remain separate PRs.
CI follow-up: registered the runtime-control integration test as a
settings_operationsconsumer after the remote static guard identified the missing edge. Consumer coverage and all 254 ownership/validation checks pass; the final affected plan adds 17 files, whose 136 tests pass. Initial local guard execution hit three 15-second timeouts under host load; the serial retry passed. This follow-up changes only test-impact metadata.