Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending proxy CONNECT and TLS handshakes have not handed their sockets to Undici, so closing the runtime network can retain these connections. Track their cancellation controllers, abort them during shutdown, and reject operations after the network closes.
The two regression cases stall CONNECT and TLS separately and verify peer EOF and request failure after shutdown. Connection and shutdown deadlines remain unchanged.
Validation: all 7 tests in
src/main/runtime-network-node.integration.test.ts, targeted ESLint, formatting and diff checks passed on macOS arm64. This standalone change is separated from #3414; it does not claim to establish the unique cause of an earlier packaged CLI shutdown failure.