Repository navigation
fix(home): unify new project button labels - #3521
Merged
Merged
Conversation
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defects. The label change is localized, reuses an existing translation key in every supported locale, preserves the existing create-dialog callback, and updates relevant renderer coverage. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defects in the pull request changes. Branch and pull request title validation passed. |
ewen-poch
enabled auto-merge
October 12, 2026 13:42
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Home header said “New project” while the empty-project action said “Create project”, although both open the same form. Reuse
t('New project')for both entry buttons (简体中文:新建项目) and update the existing render-test assertions.Scope existing E2E entry locators to the Home header: identical labels otherwise make page-wide Playwright locators ambiguous. Keep import-dialog and menu-item locators unchanged. Add English and Simplified Chinese browser coverage that opens and cancels the form through each of the two same-name entry buttons.
Existing translations cover all eight locales. The project form's submit action and all click handlers remain unchanged. No historical-data compatibility, enum/state, persistence, dependency, or public-interface changes.
Validation
Checks run after the last material edit:
npx vitest run src/renderer/src/pages/home/HomePage.render.test.tsx src/renderer/src/i18n/resources.test.ts --maxWorkers=2→ 829 tests passed.npm run typecheck:web:compiled→ passed.npx playwright test --config e2e/playwright.browser.config.ts e2e/browser/button-feedback.spec.ts e2e/browser/hover-bubble.spec.ts e2e/browser/row-hit-targets.spec.ts→ 51 passed. The Home tooltip test reproduced the strict-mode failure before scoping its locator and passed afterward.npm run lint→ passed.npx vitest run src/renderer/web/bootstrap.test.ts -t 'uses the desktop particle loader' --maxWorkers=1→ passed without changes. The earlier CI failure occurred while waiting for bootstrap API initialization, before Home renders.npm run test:affected:explain -- --base origin/main --head HEAD→ full fallback because the classifier treats the changed Electron E2E files as unknown ownership. Per the maintainer's explicit instruction, full validation is delegated to PR CI instead of running the full suite locally. The current worktree CodeGraph confirms both entries callopenCreateDialog; production ownership remainspage_home.Additional module evidence after the final production edit:
npm run test:module -- page_home/ its module runner passed 92 files and 3558 tests. A concurrent run hit the existing 15-second LiteratureLibraryPage later-import-batch-failure timeout (3557 passed); its isolated rerun passed without changes. Subsequent edits affect only E2E locators and browser tests.Independent review of the final E2E changes found no actionable issues. Existing files and imports are preserved, so module registration changes are unnecessary. The full local suite was intentionally omitted as requested. Chromium checks cover the shared renderer; native Windows journeys are delegated to the latest PR CI. No local Electron/platform certification is claimed.