Skip to content

fix(home): unify new project button labels - #3521

Merged
ewen-poch merged 2 commits into
mainfrom
fix/unify-project-button-label
Oct 12, 2026
Merged

ewen-poch merged 2 commits into
mainfrom
fix/unify-project-button-label

Conversation

@ewen-poch

@ewen-poch ewen-poch commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Summary

The Home header said “New project” while the empty-project action said “Create project”, although both open the same form. Reuse t('New project') for both entry buttons (简体中文:新建项目) and update the existing render-test assertions.

Scope existing E2E entry locators to the Home header: identical labels otherwise make page-wide Playwright locators ambiguous. Keep import-dialog and menu-item locators unchanged. Add English and Simplified Chinese browser coverage that opens and cancels the form through each of the two same-name entry buttons.

Existing translations cover all eight locales. The project form's submit action and all click handlers remain unchanged. No historical-data compatibility, enum/state, persistence, dependency, or public-interface changes.

Validation

Checks run after the last material edit:

  • Entry labels, opening/cancelling the form from either entry, and loading/error/populated states + locale integrity → npx vitest run src/renderer/src/pages/home/HomePage.render.test.tsx src/renderer/src/i18n/resources.test.ts --maxWorkers=2 → 829 tests passed.
  • Renderer types → package build and npm run typecheck:web:compiled → passed.
  • Formatting → Prettier on all changed files → passed.
  • Same-name entry behavior and existing tooltip/form interactions → npx playwright test --config e2e/playwright.browser.config.ts e2e/browser/button-feedback.spec.ts e2e/browser/hover-bubble.spec.ts e2e/browser/row-hit-targets.spec.ts → 51 passed. The Home tooltip test reproduced the strict-mode failure before scoping its locator and passed afterward.
  • Source lint → npm run lint → passed.
  • CI bootstrap failure follow-up → npx vitest run src/renderer/web/bootstrap.test.ts -t 'uses the desktop particle loader' --maxWorkers=1 → passed without changes. The earlier CI failure occurred while waiting for bootstrap API initialization, before Home renders.
  • Committed-diff impact → npm run test:affected:explain -- --base origin/main --head HEAD → full fallback because the classifier treats the changed Electron E2E files as unknown ownership. Per the maintainer's explicit instruction, full validation is delegated to PR CI instead of running the full suite locally. The current worktree CodeGraph confirms both entries call openCreateDialog; production ownership remains page_home.

Additional module evidence after the final production edit: npm run test:module -- page_home / its module runner passed 92 files and 3558 tests. A concurrent run hit the existing 15-second LiteratureLibraryPage later-import-batch-failure timeout (3557 passed); its isolated rerun passed without changes. Subsequent edits affect only E2E locators and browser tests.

Independent review of the final E2E changes found no actionable issues. Existing files and imports are preserved, so module registration changes are unnecessary. The full local suite was intentionally omitted as requested. Chromium checks cover the shared renderer; native Windows journeys are delegated to the latest PR CI. No local Electron/platform certification is claimed.

@github-actions github-actions Bot added bug Something isn't working size:S 10–29 added/deleted lines, excluding lockfiles labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defects. The label change is localized, reuses an existing translation key in every supported locale, preserves the existing create-dialog callback, and updates relevant renderer coverage.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Oct 12, 2026
@github-actions github-actions Bot added size:L 100–499 added/deleted lines, excluding lockfiles and removed ready-to-merge All completed AI reviewers found this pull request mergeable. size:S 10–29 added/deleted lines, excluding lockfiles labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defects in the pull request changes. Branch and pull request title validation passed.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Oct 12, 2026
@ewen-poch
ewen-poch enabled auto-merge October 12, 2026 13:42
@ewen-poch
ewen-poch added this pull request to the merge queue Oct 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 12, 2026
@ewen-poch
ewen-poch added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit 888bfff Oct 12, 2026
29 checks passed
@ewen-poch
ewen-poch deleted the fix/unify-project-button-label branch October 12, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-to-merge All completed AI reviewers found this pull request mergeable. size:L 100–499 added/deleted lines, excluding lockfiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant