This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Spring Boot 2 Upgrade: Part 2 - Consolidate DB Config#1367
Closed
randomnicode wants to merge 12 commits into
Closed
Spring Boot 2 Upgrade: Part 2 - Consolidate DB Config#1367randomnicode wants to merge 12 commits into
randomnicode wants to merge 12 commits into
Conversation
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
This was referenced Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1364 and further consolidates DB config.
No major changes, except componentizing most configurations.
One minor change:
Previously:
Now:
Summarily, distinction between legacy and embed profiles now is the presence of a connection pool. Both will look at external config and if absent, they'll use defaults.
This should incorporate existing behavior, and so is a non-breaking change. All existing legacy clients don't have any config, and so will fall back to defaults. All existing embed have configs, so will continue using them.
This behavior is cleaner and
At some point we should rename these profiles, and rename the environment variables accordingly (likely a breaking change). Embed db profiles for external DBs seems misleading.
This is Step 2 of a series of PRs each of which will build on each other
Next up: Remove DBCP2's Connection Pooling and switch to default Tomcat/Hikari