This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Spring Boot 2 Upgrade: Part 4 - Move Tests to Rules#1369
Closed
randomnicode wants to merge 18 commits into
Closed
Conversation
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
This was referenced Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1364, #1367 and #1368 and cleans up some tests to use the proper annotations and rules. This is necessary prior to upgrade because Spring Boot 2 does not allow the old test rules and the new to coexist.
This is Step 4 of a series of PRs each of which will build on each other
-GitHub shows the entire list of changes (including previous PRs) until previous PRs in the series are merged. This PR's diff from previous PR #1368 is the effective list of changes in it (4 commits)
Next up: Move MVC Config out of Application and into Servlet