refactor(inkless): Refactor InitDisklessLog flow and add integration tests#549
Merged
Merged
Conversation
a9520d7 to
2bdfee6
Compare
giuseppelillo
commented
Mar 24, 2026
Comment on lines
-347
to
-364
| private def sealExistingLeadersOfTopicsMigratedToDiskless(delta: MetadataDelta, newImage: MetadataImage): Unit = { | ||
| Option(delta.configsDelta()).foreach { configsDelta => | ||
| configsDelta.changes().forEach { (resource, _) => | ||
| if (resource.`type`() == ConfigResource.Type.TOPIC) { | ||
| val topicName = resource.name() | ||
| val oldProps = delta.image().configs().configProperties(resource) | ||
| val wasDiskless = oldProps.getProperty(TopicConfig.DISKLESS_ENABLE_CONFIG, "false").toBoolean | ||
| val newProps = newImage.configs().configProperties(resource) | ||
| val isDiskless = newProps.getProperty(TopicConfig.DISKLESS_ENABLE_CONFIG, "false").toBoolean | ||
| if (!wasDiskless && isDiskless) { | ||
| info(s"Topic $topicName transitioning from classic to diskless, sealing leader partitions") | ||
| replicaManager.sealTopicPartitions(topicName) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Moved all the logic inside ReplicaManager
giuseppelillo
commented
Mar 24, 2026
| // SharePartitionManager is receiving the latest changes. | ||
| verify(sharePartitionManager).onShareVersionToggle(any(), any()) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Moved tests to core/src/test/scala/unit/kafka/server/metadata/InitDisklessLogFlowTest.scala
giuseppelillo
commented
Mar 24, 2026
|
|
||
| // TODO: Add more fetch tests combinations, edge cases ara not covered yet. | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
Moved tests to core/src/test/scala/unit/kafka/server/metadata/InitDisklessLogFlowTest.scala
993a474 to
920a867
Compare
920a867 to
9c43f8d
Compare
jeqo
reviewed
Mar 24, 2026
jeqo
approved these changes
Mar 25, 2026
jeqo
pushed a commit
that referenced
this pull request
Mar 26, 2026
jeqo
pushed a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all the logic to ReplicaManager and added new tests that test the integration among BrokerMetadataPublisher, ReplicaManager and InitDisklessLogManager.