feat(inkless): POD-2386 Allow remote.storage.enabled when diskless is enabled - #556
Merged
Conversation
viktorsomogyi
marked this pull request as ready for review
March 30, 2026 13:29
viktorsomogyi
force-pushed
the
svv/ts-unification-configs
branch
from
March 31, 2026 09:36
506e6e1 to
a699d79
Compare
jeqo
reviewed
Mar 31, 2026
viktorsomogyi
marked this pull request as draft
March 31, 2026 14:37
viktorsomogyi
force-pushed
the
svv/ts-unification-configs
branch
from
April 1, 2026 13:52
a699d79 to
cbb9eca
Compare
viktorsomogyi
marked this pull request as ready for review
April 1, 2026 13:53
viktorsomogyi
force-pushed
the
svv/ts-unification-configs
branch
3 times, most recently
from
April 1, 2026 14:19
5786342 to
12a8902
Compare
jeqo
requested changes
Apr 1, 2026
jeqo
reviewed
Apr 1, 2026
jeqo
reviewed
Apr 2, 2026
jeqo
left a comment
Contributor
There was a problem hiding this comment.
Looking good. Just a few more suggestions. Let's also ensure CI is passing.
viktorsomogyi
commented
Apr 2, 2026
jeqo
reviewed
Apr 2, 2026
jeqo
reviewed
Apr 7, 2026
jeqo
left a comment
Contributor
There was a problem hiding this comment.
A last round of suggestions to make the conditions on LogConfigHelper more explicit. Apart from this it looks good to me.
jeqo
reviewed
Apr 7, 2026
jeqo
reviewed
Apr 7, 2026
jeqo
left a comment
Contributor
There was a problem hiding this comment.
Forgot to publish this one 😅 should be the last one
jeqo
previously approved these changes
Apr 7, 2026
jeqo
approved these changes
Apr 7, 2026
jeqo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @viktorsomogyi !
viktorsomogyi
force-pushed
the
svv/ts-unification-configs
branch
from
April 8, 2026 08:14
3322431 to
0c55251
Compare
viktorsomogyi
force-pushed
the
svv/ts-unification-configs
branch
from
April 8, 2026 10:16
0c55251 to
b6f36d2
Compare
jeqo
pushed a commit
that referenced
this pull request
Apr 14, 2026
jeqo
pushed a commit
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the diskless.remote.storage.consolidation.enable config. When it is enabled, it will
Setting remote.storag.enable on a diskless topic will be the intended way to start the consolidation of WAL segments into tiered topics.