feat(inkless): POD-2392 Implement consolidating partition tracking#567
Merged
Conversation
This commit implements ConsolidationFetcherManager and ConsolidationFetcherThread in ReplicaManager to track diskless partitions that are being consolidated into classic Kafka logs.
135edb8 to
d257e1c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Implements initial plumbing for tracking and fetching data for “consolidating” diskless partitions (diskless topics with remote storage enabled), wiring a new ConsolidationFetcherManager/ConsolidationFetcherThread into ReplicaManager leadership transitions.
Changes:
- Added
ConsolidationFetcherManager,ConsolidationFetcherThread, and aDisklessLeaderEndPointimplementation for consolidation fetcher threads. - Extended
MetadataView/InklessMetadataViewwithisConsolidatingDisklessTopicand updatedReplicaManagerto start/stop consolidation fetchers during leadership changes and shutdown. - Added
ConcatenatedRecords#toMemoryRecords()plus unit tests, and updated RAT exclusions for the new inkless core Scala package.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/inkless/src/test/java/io/aiven/inkless/consume/ConcatenatedRecordsTest.java | Adds unit tests for ConcatenatedRecords#toMemoryRecords() behavior. |
| storage/inkless/src/main/java/io/aiven/inkless/control_plane/MetadataView.java | Adds isConsolidatingDisklessTopic API. |
| storage/inkless/src/main/java/io/aiven/inkless/consume/ConcatenatedRecords.java | Adds toMemoryRecords() to materialize concatenated batches into a single MemoryRecords. |
| core/src/main/scala/kafka/server/ReplicaManager.scala | Wires consolidation fetcher manager into partition stop/offline/shutdown and leader/follower transitions. |
| core/src/main/scala/kafka/server/metadata/InklessMetadataView.scala | Implements isConsolidatingDisklessTopic. |
| core/src/main/scala/io/aiven/inkless/consolidation/DisklessLeaderEndPoint.scala | Introduces a LeaderEndPoint for consolidation fetchers (currently stubbed). |
| core/src/main/scala/io/aiven/inkless/consolidation/ConsolidationFetcherThread.scala | Adds toMemoryRecords override to handle ConcatenatedRecords. |
| core/src/main/scala/io/aiven/inkless/consolidation/ConsolidationFetcherManager.scala | Adds a fetcher manager to run consolidation fetchers. |
| build.gradle | Excludes core/src/main/scala/io/aiven/inkless/** from RAT checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2859
to
+2862
| if (isConsolidatingDisklessTopic) { | ||
| partition.createLogIfNotExists(isNew = true, isFutureReplica = false, offsetCheckpoints = offsetCheckpoints, topicId = partition.topicId, targetLogDirectoryId = partitionAssignedDirectoryId) | ||
| consolidatingDisklessPartitionsToStartFetching.put(tp, partition) | ||
| } |
Contributor
There was a problem hiding this comment.
This could be done in its own else if condition to improve readability, even though it requires duplicating the code to get partitionAssignedDirectoryId.
Contributor
Author
There was a problem hiding this comment.
Yea, it can be separated if you think that's better for readability. I also considered that, however I wanted the least amount of deviation from the classic code, so it seemed safer and easier to hook into this branch.
If we duplicate this code part, it carries the risk that we might miss changes in this branch in case of rebases.
jeqo
reviewed
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
giuseppelillo
approved these changes
Apr 22, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
May 6, 2026
) * feat(inkless): POD-2392 Implement consolidating partition tracking This commit implements ConsolidationFetcherManager and ConsolidationFetcherThread in ReplicaManager to track diskless partitions that are being consolidated into classic Kafka logs. * Address copilot review comments * Use full leader set to remove from fetchers * Update core/src/main/scala/kafka/server/ReplicaManager.scala Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Address copilot review comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements ConsolidationFetcherManager and ConsolidationFetcherThread in ReplicaManager to track diskless partitions that are being consolidated into classic Kafka logs.