fix(inkless:migration): catch up replicas that are below the seal#598
Merged
Conversation
Schedule a catch-up ReplicaFetcher for diskless follower partitions when the local high watermark is below classicToDisklessStartOffset (the fetcher self-evicts once the follower's log passes the seal), and also create the local log on the fly for newly added replicas of already-migrated topics.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates diskless follower handling during metadata delta application so migrated partitions with a local HW below the seal can catch up classic-era data, including newly added replicas that need a local log created on demand.
Changes:
- Adds follower catch-up scheduling when
highWatermark < classicToDisklessStartOffset. - Creates local logs for newly added replicas of already-migrated diskless topics.
- Adds unit coverage for lagging HW, unset seal offsets, and newly added migrated replicas.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/src/main/scala/kafka/server/ReplicaManager.scala |
Extends diskless follower transition logic to create logs and schedule catch-up fetchers for migrated partitions. |
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala |
Adds tests and test helper injection for replica fetcher behavior around migrated diskless followers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeqo
approved these changes
May 18, 2026
giuseppelillo
added a commit
that referenced
this pull request
May 28, 2026
Schedule a catch-up ReplicaFetcher for diskless follower partitions when the local high watermark is below classicToDisklessStartOffset (the fetcher self-evicts once the follower's log passes the seal), and also create the local log on the fly for newly added replicas of already-migrated topics.
giuseppelillo
added a commit
that referenced
this pull request
May 29, 2026
Schedule a catch-up ReplicaFetcher for diskless follower partitions when the local high watermark is below classicToDisklessStartOffset (the fetcher self-evicts once the follower's log passes the seal), and also create the local log on the fly for newly added replicas of already-migrated topics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule a catch-up ReplicaFetcher for diskless follower partitions when the local high watermark is below
classicToDisklessStartOffset(the fetcher self-evicts once the follower's log passes the seal), and also create the local log on the fly for newly added replicas of already-migrated topics.