test(inkless): add test for verifying consolidating partition reassignment [POD-2396]#599
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new integration test to ensure that when a consolidating diskless partition is reassigned, the new broker does not receive the existing local log via inter-broker transfer, and that the removed broker eventually cleans up its local log—supporting the goal of avoiding inter-zone traffic.
Changes:
- Introduces
InklessConsolidatedDisklessReassignmentTestcovering reassignment behavior during consolidation. - Adds assertions for (1) consolidation restarting on the new broker and (2) old broker log cleanup after reassignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2395d6e to
271940b
Compare
7b0b020 to
e57280e
Compare
| // LEO == originalLeaderLeo immediately. Instead, consolidation restarts from object | ||
| // storage, so the new broker should have significantly less data than the original leader. | ||
| long newBrokerLeoAfterReassignment = leoAtReassignment.get(); | ||
| assertTrue(newBrokerLeoAfterReassignment < originalLeaderLeo, |
Contributor
There was a problem hiding this comment.
I think this has the chance to be flaky. Would you mind adding a throttle to 1 on the reassignment and then lifting it once the assert is done?
viktorsomogyi
approved these changes
May 22, 2026
Contributor
|
Thank for the update, I'll merge it once the checks are green. |
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…nment (#599) [POD-2396]
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…nment (#599) [POD-2396]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test that verifies that reassignment of consolidating diskless partitions' local logs are not moved to other brokers. Instead, reassignment should restart the consolidation process on the new broker. This is to avoid inter-zone traffic