fix(inkless:fetch): properly propagate exception back on failing FetchOffset#608
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts FetchOffsetHandler.Job.start() so that failures during topic ID enrichment (e.g., TopicIdEnricher can’t resolve a topic UUID) are propagated back by completing all pending offset futures with an error, rather than throwing a bare unchecked exception that can bubble to the request handler and contribute to oversized log entries.
Changes:
- Replace
throw new RuntimeException()onTopicIdNotFoundExceptionwith completion of all pending futures using aRuntimeExceptionthat includes message and cause. - Add unit tests covering single- and multi-partition batches when topic ID resolution fails (UUID is
ZERO_UUID).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| storage/inkless/src/main/java/io/aiven/inkless/consume/FetchOffsetHandler.java | Completes all queued futures with a descriptive error on topic-ID enrichment failure instead of throwing. |
| storage/inkless/src/test/java/io/aiven/inkless/consume/FetchOffsetHandlerTest.java | Adds tests asserting futures complete with an error (and no executor/control-plane calls) when enrichment fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…hOffset The previous code threw a bare RuntimeException() without cause or message when TopicIdEnricher failed. This propagated to the request handler, which could log the full request context (all topic names) producing oversized log entries that get silently dropped by the log pipeline (journalpump → Vector → ClickHouse). Now completes all pending futures with the error, matching the existing pattern for control plane failures in queryControlPlane(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ee1bd09 to
71bb186
Compare
giuseppelillo
approved these changes
May 22, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…hOffset (#608) The previous code threw a bare RuntimeException() without cause or message when TopicIdEnricher failed. This propagated to the request handler, which could log the full request context (all topic names) producing oversized log entries that get silently dropped by the log pipeline (journalpump → Vector → ClickHouse). Now completes all pending futures with the error, matching the existing pattern for control plane failures in queryControlPlane(). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…hOffset (#608) The previous code threw a bare RuntimeException() without cause or message when TopicIdEnricher failed. This propagated to the request handler, which could log the full request context (all topic names) producing oversized log entries that get silently dropped by the log pipeline (journalpump → Vector → ClickHouse). Now completes all pending futures with the error, matching the existing pattern for control plane failures in queryControlPlane(). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code threw a bare RuntimeException() without cause or message when TopicIdEnricher failed. This propagated to the request handler, which could log the full request context (all topic names) producing oversized log entries that get silently dropped by the log pipeline (journalpump → Vector → ClickHouse).
Now completes all pending futures with the error, matching the existing pattern for control plane failures in queryControlPlane().