feat(inkless:switch): support DELETE_RECORDS for hybrid partitions#611
Merged
Conversation
348969f to
6afe6c7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds hybrid classic→diskless handling for DeleteRecords so that, when a partition has switched, the broker can truncate the local log portion and then forward the remainder of the delete to the Inkless control plane (via DeleteRecordsInterceptor), with unit tests covering key scenarios.
Changes:
- Updated
ReplicaManager.deleteRecordsto split delete requests into local vs diskless phases for hybrid partitions and to conditionally invoke the diskless interceptor. - Added unit tests for hybrid delete behavior (below start offset, past start offset, managed replicas on/off, and local-delete failure case).
- Introduced a test helper to set up a leader hybrid partition with a seeded local log.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/main/scala/kafka/server/ReplicaManager.scala | Implements two-phase delete handling for hybrid partitions and routes diskless deletes through DeleteRecordsInterceptor. |
| core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala | Adds coverage for hybrid delete-records behavior and a helper to construct hybrid leader partitions for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6afe6c7 to
e1ed1e3
Compare
e1ed1e3 to
1e4ecc6
Compare
jeqo
reviewed
May 25, 2026
jeqo
reviewed
May 26, 2026
jeqo
left a comment
Contributor
There was a problem hiding this comment.
one last comment before approving
jeqo
approved these changes
May 26, 2026
viktorsomogyi
approved these changes
May 27, 2026
giuseppelillo
added a commit
that referenced
this pull request
May 29, 2026
giuseppelillo
added a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle DELETE_RECORDS in case of topics being switched from classic to diskless and/or consolidating to Tiered Storage.