refactor(inkless:consolidation): rename and improve ConsolidationMetrics#621
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Inkless consolidation metrics to align naming with other Kafka metrics and adds broker-level aggregate gauges to support alerting across partitions.
Changes:
- Renamed consolidation gauge names from
inkless.remote.consolidation.*toConsolidation*. - Added broker-level (unscoped) aggregate gauges that sum values across all registered partitions.
- Updated fetcher thread and unit tests to use the new metric names and validate the aggregate behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/scala/io/aiven/inkless/consolidation/ConsolidationMetrics.scala | Renames metric names, adds broker-level aggregate gauges, updates registration/unregistration logic. |
| core/src/main/scala/io/aiven/inkless/consolidation/ConsolidationFetcherThread.scala | Switches from updateLag to updateTotalLag for the renamed metric. |
| core/src/test/scala/io/aiven/inkless/consolidation/ConsolidationFetcherThreadTest.scala | Updates assertions for renamed metrics and adds coverage for broker-level aggregates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
15c8e22 to
c297b44
Compare
Rename metric names from dot-separated `inkless.remote.consolidation.*` to CamelCase `Consolidation*` aligned with other Kafka metrics. Add broker-level aggregate gauges (sum across partitions) for alerting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c297b44 to
383fdc5
Compare
viktorsomogyi
approved these changes
May 29, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…ics (#621) Rename metric names from dot-separated `inkless.remote.consolidation.*` to CamelCase `Consolidation*` aligned with other Kafka metrics. Add broker-level aggregate gauges (sum across partitions) for alerting. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
giuseppelillo
pushed a commit
that referenced
this pull request
May 29, 2026
…ics (#621) Rename metric names from dot-separated `inkless.remote.consolidation.*` to CamelCase `Consolidation*` aligned with other Kafka metrics. Add broker-level aggregate gauges (sum across partitions) for alerting. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename metric names from dot-separated
inkless.remote.consolidation.*to CamelCaseConsolidation*aligned with other Kafka metrics. Add broker-level aggregate gauges (sum across partitions) for alerting.