fix(inkless): ensure ReplicaManager shutdown in Inkless tests - #623
Merged
Conversation
Contributor
Author
|
Running Nightly CI manually on this branch to check if it goes green again: https://github.com/aiven/inkless/actions/runs/26640104032 |
jeqo
force-pushed
the
jeqo/fix-replica-manager-test
branch
from
May 29, 2026 13:56
c51f1b5 to
3754fec
Compare
Contributor
Author
Move replicaManager initialization outside try blocks so shutdown can be placed in finally, preventing executor-Fetch thread leaks that cause verifyNoUnexpectedThreads failures in CI nightly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeqo
force-pushed
the
jeqo/fix-replica-manager-test
branch
from
May 29, 2026 15:05
3754fec to
154914c
Compare
Contributor
Author
|
CI back to green, testing Nightly CI again: https://github.com/aiven/inkless/actions/runs/26646059681 |
Contributor
Author
|
Nightly CI is green again 🟢 |
jeqo
marked this pull request as ready for review
May 29, 2026 16:38
tvainika
approved these changes
Jun 1, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Jun 4, 2026
Move replicaManager initialization outside try blocks so shutdown can be placed in finally, preventing executor-Fetch thread leaks that cause verifyNoUnexpectedThreads failures in CI nightly. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move replicaManager initialization outside try blocks so shutdown can be placed in finally, preventing executor-Fetch thread leaks that cause verifyNoUnexpectedThreads failures in CI nightly.