refactor(inkless): extract Inkless tests from ReplicaManagerTest into standalone file#624
Merged
Merged
Conversation
jeqo
commented
May 29, 2026
Contributor
- 94+2 tests moved, reducing ReplicaManagerTest from ~11k to ~6.1k lines
- Zero Inkless code left in the original file
- CI glob Inkless still matches
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3754fec to
154914c
Compare
779a45c to
b45cbfb
Compare
618b139 to
3830307
Compare
… standalone file Move the @nested class Inkless (94 tests, ~5000 lines) into ReplicaManagerInklessTest.scala as a top-level class with its own setUp/tearDown. This reduces ReplicaManagerTest from ~11k to ~6k lines and isolates Inkless test maintenance from upstream Kafka test churn. CI glob *Inkless* matches the new class name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…gerInklessTest Move testFetchFollowerAllowedForOlderClientsOnHybridDisklessPartition and testFetchFromFollowerStillRequiresLeaderOnSwitchedPartition into the Inkless test file with a simplified setupReplicaManagerWithMockedPurgatories helper. This eliminates all Inkless-specific test code from ReplicaManagerTest.scala, leaving only import-path differences from upstream Kafka. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for every module with Inkless-modified source files: - metadata: controller.*, controller.metrics.*, PartitionRegistrationTest, TopicsImageTest - core: ReplicaManagerTest, KafkaApisTest, PartitionTest, DynamicBrokerConfigTest, DynamicConfigChangeTest, ReplicaFetcherThreadTest, BrokerMetadataPublisherTest, ControllerApisTest, ControllerConfigurationValidatorTest, DelayedFetchTest - clients: RequestResponseTest, FlattenedIteratorTest - storage: BrokerTopicMetricsTest, BrokerTopicStatsTest - server: RequestConvertToJsonTest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3830307 to
facfd6a
Compare
viktorsomogyi
approved these changes
Jun 1, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Jun 4, 2026
… standalone file (#624) Move the @nested class Inkless (94 tests, ~5000 lines) into ReplicaManagerInklessTest.scala as a top-level class with its own setUp/tearDown. This reduces ReplicaManagerTest from ~11k to ~6k lines and isolates Inkless test maintenance from upstream Kafka test churn. Move testFetchFollowerAllowedForOlderClientsOnHybridDisklessPartition and testFetchFromFollowerStillRequiresLeaderOnSwitchedPartition into the Inkless test file with a simplified setupReplicaManagerWithMockedPurgatories helper. This eliminates all Inkless-specific test code from ReplicaManagerTest.scala, leaving only import-path differences from upstream Kafka. Add tests for every module with Inkless-modified source files: - metadata: controller.*, controller.metrics.*, PartitionRegistrationTest, TopicsImageTest - core: ReplicaManagerTest, KafkaApisTest, PartitionTest, DynamicBrokerConfigTest, DynamicConfigChangeTest, ReplicaFetcherThreadTest, BrokerMetadataPublisherTest, ControllerApisTest, ControllerConfigurationValidatorTest, DelayedFetchTest - clients: RequestResponseTest, FlattenedIteratorTest - storage: BrokerTopicMetricsTest, BrokerTopicStatsTest - server: RequestConvertToJsonTest --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gqmelo
pushed a commit
that referenced
this pull request
Jun 4, 2026
… standalone file (#624) Move the @nested class Inkless (94 tests, ~5000 lines) into ReplicaManagerInklessTest.scala as a top-level class with its own setUp/tearDown. This reduces ReplicaManagerTest from ~11k to ~6k lines and isolates Inkless test maintenance from upstream Kafka test churn. Move testFetchFollowerAllowedForOlderClientsOnHybridDisklessPartition and testFetchFromFollowerStillRequiresLeaderOnSwitchedPartition into the Inkless test file with a simplified setupReplicaManagerWithMockedPurgatories helper. This eliminates all Inkless-specific test code from ReplicaManagerTest.scala, leaving only import-path differences from upstream Kafka. Add tests for every module with Inkless-modified source files: - metadata: controller.*, controller.metrics.*, PartitionRegistrationTest, TopicsImageTest - core: ReplicaManagerTest, KafkaApisTest, PartitionTest, DynamicBrokerConfigTest, DynamicConfigChangeTest, ReplicaFetcherThreadTest, BrokerMetadataPublisherTest, ControllerApisTest, ControllerConfigurationValidatorTest, DelayedFetchTest - clients: RequestResponseTest, FlattenedIteratorTest - storage: BrokerTopicMetricsTest, BrokerTopicStatsTest - server: RequestConvertToJsonTest --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.