fix(inkless): Remove consolidating fetchers unconditionally#629
Merged
Conversation
viktorsomogyi
force-pushed
the
svv/ts-unification-racy-remove
branch
from
June 8, 2026 14:31
a44df3f to
07397da
Compare
viktorsomogyi
marked this pull request as ready for review
June 8, 2026 14:33
viktorsomogyi
force-pushed
the
svv/ts-unification-racy-remove
branch
2 times, most recently
from
June 8, 2026 14:37
78b05a2 to
8751c09
Compare
Filtering by the metadata view in stopPartitions is racy because when a diskless topic is deleted it may already be gone from the metadata view by the time we get there, so isConsolidatingDisklessTopic would return false and leave the partitions orphaned in the consolidation fetcher.
viktorsomogyi
force-pushed
the
svv/ts-unification-racy-remove
branch
from
June 8, 2026 14:38
8751c09 to
f578c27
Compare
EelisK
approved these changes
Jun 8, 2026
giuseppelillo
approved these changes
Jun 9, 2026
jeqo
pushed a commit
that referenced
this pull request
Jun 10, 2026
Filtering by the metadata view in stopPartitions is racy because when a diskless topic is deleted it may already be gone from the metadata view by the time we get there, so isConsolidatingDisklessTopic would return false and leave the partitions orphaned in the consolidation fetcher.
jeqo
pushed a commit
that referenced
this pull request
Jun 10, 2026
Filtering by the metadata view in stopPartitions is racy because when a diskless topic is deleted it may already be gone from the metadata view by the time we get there, so isConsolidatingDisklessTopic would return false and leave the partitions orphaned in the consolidation fetcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata is updated sooner than the applyDelta is being called, so checking whether the partition is consolidating there is incorrect. Since
removeFetcherForPartitionsignore partitions it can't find, it's simpler and safer not to filter there.