fix(inkless:metrics): exclude consolidating partitions from URP metrics#640
Open
jeqo wants to merge 2 commits into
Open
fix(inkless:metrics): exclude consolidating partitions from URP metrics#640jeqo wants to merge 2 commits into
jeqo wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates broker-level under-replicated partition (URP) metrics to exclude consolidating diskless topics, which can appear perpetually under-replicated because their follower replicas never materialize, and adds a unit test to lock in the intended behavior.
Changes:
- Exclude consolidating diskless topics from
ReplicaManager.underReplicatedPartitionCount. - Add a unit test asserting URP count ignores consolidating diskless partitions but still counts classic under-replication.
- Update
.gitignoreto ignore Inkless sync output andcore/data/.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/scala/kafka/server/ReplicaManager.scala | Adjusts URP counting logic to skip consolidating diskless topics. |
| core/src/test/scala/unit/kafka/server/ReplicaManagerInklessTest.scala | Adds a regression test for the updated URP counting behavior. |
| .gitignore | Ignores additional generated/local data directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3552e7f to
1bf3920
Compare
1bf3920 to
58132ec
Compare
Contributor
Author
|
|
58132ec to
b6c8942
Compare
Consolidating diskless partitions never materialize followers (ReplicaManager skips getOrCreatePartition for them), so they always trip URP-related gauges (underReplicatedPartitionCount, atMinIsrPartitionCount, underMinIsrPartitionCount) despite having dedicated ConsolidationLocalLag/TotalLag metrics for observability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b6c8942 to
17e48b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
underReplicatedPartitionCount,atMinIsrPartitionCount, andunderMinIsrPartitionCountgaugesgetOrCreatePartitionfor them), so they always trip URP-related alerts despite being healthy from a consolidation standpointConsolidationLocalLag/TotalLagmetrics