Skip to content

fix(inkless:ci): fix RequestQuotaTest and make CI test failures visible #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvainika merged 4 commits into from
Jul 9, 2026
Merged

fix(inkless:ci): fix RequestQuotaTest and make CI test failures visible #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af5934b
fix(inkless:test): handle ALTER_DISKLESS_SWITCH in RequestQuotaTest
jeqo Jul 9, 2026
affc216
fix(inkless:ci): correct nightly JUnit report path
jeqo Jul 9, 2026
147bbb3
fix(inkless:ci): retry kafka-owned tests, keep inkless tests unretried
jeqo Jul 9, 2026
1ba8d27
fix(inkless:ci): enforce the test timeout across the whole suite chain
jeqo Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/inkless-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,16 @@ jobs:
set +e
./.github/scripts/thread-dump.sh &
# inkless tests
timeout ${TIMEOUT_MINUTES}m \
# Wrap the whole chain in a single timeout so a hang in any suite is
# killed and yields exit 124, which triggers the thread-dump upload.
timeout ${TIMEOUT_MINUTES}m bash -c '
./gradlew ${GRADLE_ARGS} :storage:inkless:test :storage:inkless:integrationTest && \
./gradlew ${GRADLE_ARGS} :metadata:test --tests "org.apache.kafka.controller.*" && \
./gradlew ${GRADLE_ARGS} :core:test --tests "*Inkless*" --tests "*Diskless*" && \
./gradlew ${GRADLE_ARGS} :core:test --tests "kafka.server.*" && \
./gradlew ${GRADLE_ARGS} :core:test --tests "kafka.api.*" && \
./gradlew ${GRADLE_ARGS} :core:test --tests "kafka.log.*"
'
exitcode="$?"
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
- name: Archive JUnit HTML reports
Expand Down Expand Up @@ -109,7 +112,7 @@ jobs:
THREAD_DUMP_URL: ${{ steps.thread-dump-upload-artifact.outputs.artifact-url }}
GRADLE_TEST_EXIT_CODE: ${{ steps.junit-test.outputs.exitcode }}
run: |
python .github/scripts/junit.py --path build/junit-xml/${{ matrix.java }} >> $GITHUB_STEP_SUMMARY
python .github/scripts/junit.py --path build/junit-xml >> $GITHUB_STEP_SUMMARY
- name: Archive Test Catalog
if: ${{ always() && matrix.java == '21' }}
uses: actions/upload-artifact@v4
Expand Down
32 changes: 20 additions & 12 deletions .github/workflows/inkless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,30 @@ jobs:
-x generateJooqClasses
-PtestLoggingEvents=started,passed,skipped,failed
-PmaxParallelForks=2
-PmaxTestRetries=0
-PmaxQuarantineTestRetries=3 -PmaxQuarantineTestRetryFailures=0
-Pkafka.test.xml.output.dir=${{ matrix.java }}
-PcommitId=xxxxxxxxxxxxxxxx
# Inkless-owned tests run without retries so we catch our own flakiness.
INKLESS_RETRY_ARGS: -PmaxTestRetries=0
# Kafka-owned tests are retried to tolerate known upstream flakiness.
KAFKA_RETRY_ARGS: -PmaxTestRetries=1 -PmaxTestRetryFailures=3
# Point to inkless tests
run: |
set +e
./.github/scripts/thread-dump.sh &
# inkless tests
timeout ${TIMEOUT_MINUTES}m \
./gradlew ${GRADLE_ARGS} :storage:inkless:test :storage:inkless:integrationTest && \
./gradlew ${GRADLE_ARGS} :metadata:test \
# Wrap the whole chain in a single timeout so a hang in any suite is
# killed and yields exit 124, which triggers the thread-dump upload.
timeout ${TIMEOUT_MINUTES}m bash -c '
# Inkless-owned tests (no retries)
./gradlew ${GRADLE_ARGS} ${INKLESS_RETRY_ARGS} :storage:inkless:test :storage:inkless:integrationTest && \
./gradlew ${GRADLE_ARGS} ${INKLESS_RETRY_ARGS} :core:test \
--tests "*Inkless*" --tests "*Diskless*" \
--tests "io.aiven.inkless.*" && \
./gradlew ${GRADLE_ARGS} ${KAFKA_RETRY_ARGS} :metadata:test \
--tests "org.apache.kafka.controller.*" \
--tests "org.apache.kafka.metadata.PartitionRegistrationTest" \
--tests "org.apache.kafka.image.TopicsImageTest" && \
./gradlew ${GRADLE_ARGS} :core:test \
--tests "*Inkless*" --tests "*Diskless*" \
--tests "io.aiven.inkless.*" \
./gradlew ${GRADLE_ARGS} ${KAFKA_RETRY_ARGS} :core:test \
--tests "kafka.log.LogConfigTest" \
--tests "kafka.server.KafkaConfigTest" \
--tests "kafka.server.ReplicaManagerTest" \
Expand All @@ -183,15 +189,17 @@ jobs:
--tests "kafka.server.metadata.BrokerMetadataPublisherTest" \
--tests "kafka.server.ControllerApisTest" \
--tests "kafka.server.ControllerConfigurationValidatorTest" \
--tests "kafka.server.DelayedFetchTest" && \
./gradlew ${GRADLE_ARGS} :clients:test \
--tests "kafka.server.DelayedFetchTest" \
--tests "kafka.server.RequestQuotaTest" && \
./gradlew ${GRADLE_ARGS} ${KAFKA_RETRY_ARGS} :clients:test \
--tests "org.apache.kafka.common.requests.RequestResponseTest" \
--tests "org.apache.kafka.common.utils.FlattenedIteratorTest" && \
./gradlew ${GRADLE_ARGS} :storage:test \
./gradlew ${GRADLE_ARGS} ${KAFKA_RETRY_ARGS} :storage:test \
--tests "org.apache.kafka.storage.log.metrics.BrokerTopicMetricsTest" \
--tests "org.apache.kafka.storage.log.metrics.BrokerTopicStatsTest" && \
./gradlew ${GRADLE_ARGS} :server:test \
./gradlew ${GRADLE_ARGS} ${KAFKA_RETRY_ARGS} :server:test \
--tests "org.apache.kafka.network.RequestConvertToJsonTest"
'
exitcode="$?"
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
- name: Archive JUnit HTML reports
Expand Down
3 changes: 3 additions & 0 deletions core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,9 @@ class RequestQuotaTest extends BaseRequestTest {
case ApiKeys.DELETE_SHARE_GROUP_OFFSETS =>
new DeleteShareGroupOffsetsRequest.Builder(new DeleteShareGroupOffsetsRequestData())

case ApiKeys.ALTER_DISKLESS_SWITCH =>
new AlterDisklessSwitchRequest.Builder(new AlterDisklessSwitchRequestData())

case _ =>
throw new IllegalArgumentException("Unsupported API key " + apiKey)
}
Expand Down
Loading