fix(inkless:switch): [KC-234] force-roll boundary segment at seal so idle switched topics tier their classic tail - #694
Merged
Conversation
viktorsomogyi
force-pushed
the
svv/ts-unification-close-after-seal
branch
from
July 13, 2026 14:39
1ecf54a to
a52c931
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a classic→diskless switch edge case where sealing a partition froze LEO but left the boundary segment active, preventing RemoteLogManager from tiering the classic tail when the topic becomes idle (KC-234). It ensures the boundary becomes a closed segment by force-rolling after sealing, and adds an integration test to assert latest-tiered reaches the pre-switch seal offset even with no post-switch appends.
Changes:
- Force-roll the active log segment during
Partition.seal()so[base_active, LEO)becomes a closed tiering candidate. - Add a new integration test covering the “idle switched topic tiers classic tail” scenario (KC-234).
- Refactor the integration test to reuse helper methods for large-record production, switching, and “tiered object exists” waiting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/main/scala/kafka/cluster/Partition.scala | Rolls the active segment during sealing to make the classic tail eligible for RLM tiering. |
| core/src/test/java/kafka/server/InklessConsolidatedDisklessTopicsTest.java | Adds KC-234 regression test and small helper refactors around switching and tiering evidence. |
viktorsomogyi
force-pushed
the
svv/ts-unification-close-after-seal
branch
from
July 14, 2026 08:14
a52c931 to
ce3383c
Compare
viktorsomogyi
marked this pull request as ready for review
July 14, 2026 12:50
…enable tiering seal() froze LEO but left the boundary [base_active, seal) as the active segment. RLM only tiers closed segments, so an idle switched topic never copied its classic tail to remote. Force-roll the active segment after aborting transactions and setting _sealed so it becomes a tiering candidate. # Conflicts: # core/src/test/java/kafka/server/InklessConsolidatedDisklessTopicsTest.java
viktorsomogyi
force-pushed
the
svv/ts-unification-close-after-seal
branch
from
July 16, 2026 07:53
ce3383c to
ea74d30
Compare
ivanyu
approved these changes
Jul 22, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Jul 29, 2026
…enable tiering (#694) seal() froze LEO but left the boundary [base_active, seal) as the active segment. RLM only tiers closed segments, so an idle switched topic never copied its classic tail to remote. Force-roll the active segment after aborting transactions and setting _sealed so it becomes a tiering candidate. # Conflicts: # core/src/test/java/kafka/server/InklessConsolidatedDisklessTopicsTest.java
giuseppelillo
pushed a commit
that referenced
this pull request
Jul 30, 2026
…enable tiering (#694) seal() froze LEO but left the boundary [base_active, seal) as the active segment. RLM only tiers closed segments, so an idle switched topic never copied its classic tail to remote. Force-roll the active segment after aborting transactions and setting _sealed so it becomes a tiering candidate. # Conflicts: # core/src/test/java/kafka/server/InklessConsolidatedDisklessTopicsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seal() froze LEO but left the boundary [base_active, seal) as the active segment. RLM only tiers closed segments, so an idle switched topic never copied its classic tail to remote. Force-roll the active segment after aborting transactions and setting _sealed so it becomes a tiering candidate.