fix(inkless:ci): guard JUnit parsing against killed-test reports - #696
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Inkless CI resilience when the timeout wrapper kills hung test runs, which can leave behind empty/truncated JUnit XML that breaks the upstream .github/scripts/junit.py parser. The workflows now surface timeout-kills explicitly and prune unparseable JUnit XML before parsing so job summaries still render and the underlying failure is reflected via GRADLE_TEST_EXIT_CODE.
Changes:
- Emit explicit GitHub Actions
::error::annotations + job summary section when tests are killed by the timeout wrapper (exit 124). - Prune unparseable JUnit XML reports before invoking
junit.pyso parsing doesn’t crash on truncated/empty XML. - Increase nightly workflow timeout headroom to 120 minutes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/inkless.yml | Adds timeout-kill annotations and prunes invalid JUnit XML before parsing to keep summaries working on partial results. |
| .github/workflows/inkless-nightly.yml | Same guardrails as inkless.yml, plus increases the test timeout to 120 minutes for full nightly suites. |
jeqo
force-pushed
the
jeqo/fix-nightly-ci
branch
from
July 14, 2026 08:13
3ee6ac8 to
1646af9
Compare
jeqo
marked this pull request as ready for review
July 14, 2026 08:20
jeqo
force-pushed
the
jeqo/fix-nightly-ci
branch
from
July 14, 2026 08:33
1646af9 to
5c67292
Compare
A hung test that trips the timeout wrapper leaves empty or truncated JUnit XML files, which crash junit.py (an upstream script we keep unmodified) with "ParseError: no element found". Add a prune step to both inkless workflows that drops unparseable reports before parsing, so a summary is still produced and the real failure surfaces via GRADLE_TEST_EXIT_CODE. Also make timeout kills explicit: on exit 124 the Test step now emits an ::error:: annotation and a job-summary section instead of burying the reason in the step log. Bump the nightly timeout to 120m (it hit 30m on every recent run); inkless.yml stays at 30m since its curated subset finishes well under it.
jeqo
force-pushed
the
jeqo/fix-nightly-ci
branch
from
July 14, 2026 08:38
5c67292 to
f8b9896
Compare
EelisK
approved these changes
Jul 14, 2026
jeqo
added a commit
that referenced
this pull request
Jul 20, 2026
A hung test that trips the timeout wrapper leaves empty or truncated JUnit XML files, which crash junit.py (an upstream script we keep unmodified) with "ParseError: no element found". Add a prune step to both inkless workflows that drops unparseable reports before parsing, so a summary is still produced and the real failure surfaces via GRADLE_TEST_EXIT_CODE. Also make timeout kills explicit: on exit 124 the Test step now emits an ::error:: annotation and a job-summary section instead of burying the reason in the step log. Bump the nightly timeout to 120m (it hit 30m on every recent run); inkless.yml stays at 30m since its curated subset finishes well under it.
jeqo
added a commit
that referenced
this pull request
Jul 20, 2026
A hung test that trips the timeout wrapper leaves empty or truncated JUnit XML files, which crash junit.py (an upstream script we keep unmodified) with "ParseError: no element found". Add a prune step to both inkless workflows that drops unparseable reports before parsing, so a summary is still produced and the real failure surfaces via GRADLE_TEST_EXIT_CODE. Also make timeout kills explicit: on exit 124 the Test step now emits an ::error:: annotation and a job-summary section instead of burying the reason in the step log. Bump the nightly timeout to 120m (it hit 30m on every recent run); inkless.yml stays at 30m since its curated subset finishes well under it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hung test that trips the timeout wrapper leaves empty or truncated JUnit XML files, which crash junit.py (an upstream script we keep unmodified) with "ParseError: no element found". Add a prune step to both inkless workflows that drops unparseable reports before parsing, so a summary is still produced and the real failure surfaces via GRADLE_TEST_EXIT_CODE. e.g., https://github.com/aiven/inkless/actions/runs/29296786453/job/86971965671
Also make timeout kills explicit: on exit 124 the Test step now emits an ::error:: annotation and a job-summary section instead of burying the reason in the step log.
Bump the nightly timeout to 120m (it hit 30m on every recent run); inkless.yml stays at 30m since its curated subset finishes well under it.