feat(inkless): surface inkless version at startup and in --version output - #717
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR surfaces Inkless’s git tag/describe information in the runtime --version output by baking an inklessVersion field into kafka-version.properties at build time, and also fixes release tooling by deriving the Makefile’s distribution VERSION from gradle.properties.
Changes:
- Add
inklessVersionto the generatedkafka-version.propertiesand expose it viaAppInfoParser.getInklessVersion(). - Append Inkless version info to broker/tool
--versionoutputs. - Make
MakefilecomputeVERSIONfromgradle.propertiesinstead of hardcoding it.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/src/main/java/org/apache/kafka/tools/PrintVersionAndExitAction.java | Extends tool --version output to include Inkless version info. |
| server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java | Extends common --version path (used by multiple CLIs) to include Inkless version info. |
| Makefile | Derives distribution VERSION from gradle.properties for correct release/docker artifacts. |
| clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java | Adds inklessVersion parsing + accessor from baked version properties. |
| build.gradle | Computes and writes inklessVersion into baked version files across subprojects. |
jeqo
force-pushed
the
jeqo/inkless-release-log
branch
from
July 22, 2026 18:57
34ab856 to
47d07ed
Compare
jeqo
force-pushed
the
jeqo/inkless-release-log
branch
from
July 29, 2026 15:24
47d07ed to
47abc43
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java:158
- The startup log guard only checks for
"unknown"; ifinklessVersionis present but empty/whitespace (e.g., set via-PinklessVersion=), this will emit an empty "Inkless version:" line. The guard should matchgetInklessVersionSuffix()semantics (suppress for empty/unknown).
// INKLESS: log the inkless tag/increment at startup when baked in (see build.gradle).
if (!DEFAULT_VALUE.equals(INKLESS_VERSION)) {
log.info("Inkless version: {}", INKLESS_VERSION);
}
jeqo
force-pushed
the
jeqo/inkless-release-log
branch
from
July 29, 2026 15:50
47abc43 to
b2136ea
Compare
Bake git describe --tags --match 'inkless-*' into kafka-version.properties as inklessTag (via providers.exec, worktree-aware) and expose it through AppInfoParser.getInklessTag(). Log it at broker/client startup ("Inkless tag: <describe>") alongside the existing Kafka version/commitId lines, and append it as a " (Inkless:<tag>)" suffix to the broker/tools --version output. Both are gated on the tag being baked in (non-empty and not "unknown"), so upstream output/logs are unchanged when it is absent (e.g. off a non-release build).
Also derive Makefile VERSION from gradle.properties instead of hardcoding 4.2.0-inkless-SNAPSHOT, so build_release/docker are correct on any checkout (inkless-4.1 hardcoded 4.1.0 while its gradle.properties said 4.1.2).
jeqo
force-pushed
the
jeqo/inkless-release-log
branch
from
July 29, 2026 15:52
b2136ea to
32c4739
Compare
jeqo
marked this pull request as ready for review
July 29, 2026 15:52
giuseppelillo
approved these changes
Jul 29, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Jul 30, 2026
…#717) Bake git describe --tags --match 'inkless-*' into kafka-version.properties as inklessTag (via providers.exec, worktree-aware) and expose it through AppInfoParser.getInklessTag(). Log it at broker/client startup ("Inkless tag: <describe>") alongside the existing Kafka version/commitId lines, and append it as a " (Inkless:<tag>)" suffix to the broker/tools --version output. Both are gated on the tag being baked in (non-empty and not "unknown"), so upstream output/logs are unchanged when it is absent (e.g. off a non-release build). Also derive Makefile VERSION from gradle.properties instead of hardcoding 4.2.0-inkless-SNAPSHOT, so build_release/docker are correct on any checkout (inkless-4.1 hardcoded 4.1.0 while its gradle.properties said 4.1.2).
giuseppelillo
pushed a commit
that referenced
this pull request
Jul 30, 2026
…#717) Bake git describe --tags --match 'inkless-*' into kafka-version.properties as inklessTag (via providers.exec, worktree-aware) and expose it through AppInfoParser.getInklessTag(). Log it at broker/client startup ("Inkless tag: <describe>") alongside the existing Kafka version/commitId lines, and append it as a " (Inkless:<tag>)" suffix to the broker/tools --version output. Both are gated on the tag being baked in (non-empty and not "unknown"), so upstream output/logs are unchanged when it is absent (e.g. off a non-release build). Also derive Makefile VERSION from gradle.properties instead of hardcoding 4.2.0-inkless-SNAPSHOT, so build_release/docker are correct on any checkout (inkless-4.1 hardcoded 4.1.0 while its gradle.properties said 4.1.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bake git describe --tags --match 'inkless-*' into kafka-version.properties as inklessTag (via providers.exec, worktree-aware) and expose it through AppInfoParser.getInklessTag(). Log it at broker/client startup ("Inkless tag: ") alongside the existing Kafka version/commitId lines, and append it as a " (Inkless:)" suffix to the broker/tools --version output. Both are gated on the tag being baked in (non-empty and not "unknown"), so upstream output/logs are unchanged when it is absent (e.g. off a non-release build).
Also derive Makefile VERSION from gradle.properties instead of hardcoding 4.2.0-inkless-SNAPSHOT, so build_release/docker are correct on any checkout (inkless-4.1 hardcoded 4.1.0 while its gradle.properties said 4.1.2).