Repository navigation
fix(inkless:consolidation): start consolidation when remote storage is enabled later [KC-540] #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
357ccdf
fix(inkless:consolidation): start consolidation when remote storage i…
viktorsomogyi 259fa47
fix(inkless:consolidation): require remote coverage of the WAL-gap bo…
viktorsomogyi c14f35c
test(inkless:consolidation): replay the late-enable epoch bump on the…
viktorsomogyi d9c66c0
fix(inkless:consolidation): ignore stale remote-prefix unknown updates
viktorsomogyi 94c17ef
fix(inkless:consolidation): capture remote-prefix generation before d…
viktorsomogyi f19b752
fix(inkless:consolidation): keep remote-prefix generations monotonic …
viktorsomogyi d5510d9
fix(inkless:consolidation): capture remote-prefix generation in build…
viktorsomogyi deaea58
fix(inkless:consolidation): drop live remote-prefix generation reads …
viktorsomogyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: Keeping the counter fixes generation reuse, but it retains the
TopicPartitionand topic name for every partition until broker shutdown. Repeated topic churn can therefore grow this map without bound. A broker-wideAtomicLongcould assign globally unique generation tokens, allowingunregisterPartitionto remove the per-partition entry without letting a later registration reuse an old token. This can also be addressed in a follow-up PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the PR size, I think we should do it as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, approved