Skip to content

fix(inkless:build): enable Zip64 for the JMH shadow jar - #810

Merged
viktorsomogyi merged 1 commit into
mainfrom
svv/fix-gzip-issue
Sep 28, 2026
Merged

viktorsomogyi merged 1 commit into
mainfrom
svv/fix-gzip-issue

Conversation

@viktorsomogyi

Copy link
Copy Markdown
Contributor

:jmh-benchmarks:shadowJar shades a runtime classpath of more than 65535 entries. Classic Zip cannot store that many, so ./gradlew build fails with Zip64RequiredException on every branch that shares this classpath. Enabling Zip64 lets the task write the archive.

Assisted-by: Grok 4.7

@viktorsomogyi
viktorsomogyi marked this pull request as ready for review September 24, 2026 13:27
@giuseppelillo
giuseppelillo requested a balanced review from Copilot September 24, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`:jmh-benchmarks:shadowJar` shades a runtime classpath of more than 65535 entries. Classic Zip cannot store that many, so `./gradlew build` fails with Zip64RequiredException on every branch that shares this classpath. Enabling Zip64 lets the task write the archive.

ssisted-by: Grok 4.7
@viktorsomogyi
viktorsomogyi merged commit c174458 into main Sep 28, 2026
4 checks passed
@viktorsomogyi
viktorsomogyi deleted the svv/fix-gzip-issue branch September 28, 2026 08:07
jeqo pushed a commit that referenced this pull request Oct 19, 2026
`:jmh-benchmarks:shadowJar` shades a runtime classpath of more than 65535 entries. Classic Zip cannot store that many, so `./gradlew build` fails with Zip64RequiredException on every branch that shares this classpath. Enabling Zip64 lets the task write the archive.

Assisted-by: Grok 4.7
jeqo pushed a commit that referenced this pull request Oct 19, 2026
`:jmh-benchmarks:shadowJar` shades a runtime classpath of more than 65535 entries. Classic Zip cannot store that many, so `./gradlew build` fails with Zip64RequiredException on every branch that shares this classpath. Enabling Zip64 lets the task write the archive.

Assisted-by: Grok 4.7
jeqo pushed a commit that referenced this pull request Oct 19, 2026
`:jmh-benchmarks:shadowJar` shades a runtime classpath of more than 65535 entries. Classic Zip cannot store that many, so `./gradlew build` fails with Zip64RequiredException on every branch that shares this classpath. Enabling Zip64 lets the task write the archive.

Assisted-by: Grok 4.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants