fix(inkless:test): raise S3 timeouts and avoid the isolated broker in switch systests - #813

… switch systests (#813)

* fix(inkless:test): raise S3 timeouts and avoid the isolated broker in switch systests

Six `InklessClassicToDisklessSwitchTest` cases fail on the nightly run for
two reasons unrelated to the switch itself.

#791 set the S3 client defaults to a 2 s call timeout and a 1 s attempt
timeout. The degraded-network tests throttle every broker NIC, including the
path to MinIO, to 2 Mbit/s with 200 ms latency, so WAL uploads outlast 2 s
and fail with `ApiCallTimeoutException`. The producer retries each failed
produce, so it either never recovers or the consumer reads more records than
were acked. `_create_kafka` now sets the call timeout to 60 s and the attempt
timeout to 30 s. That fixes `test_switch_follower_crash_with_lagged_hw`,
`test_switch_leader_crash` (both variants), `test_switch_leader_restart`, and
`test_switch_rolling_restart`, which have failed since #791 merged.

`test_switch_follower_network_partition` isolates a follower and then runs
`kafka-configs.sh` from `self.nodes[0]`. When that node is the isolated
follower, the admin client can't reach its peers, and the describe that
precedes the alter hits its 30 s limit. `_switch_topic_to_diskless` now takes
a `node`, and both network-partition tests pass one from the reachable side.
`test_switch_leader_network_partition` has the same latent bug, since the
leader can also be `self.nodes[0]`.

## Test plan

Run the Inkless System Tests workflow on this branch and check that the six
cases pass. `test_switched_topic_urp_clears_after_replica_recovery` still
fails: that failure is the stranded-follower bug fixed by #760.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix comment formatting in inkless_topic_switch_test.py

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

… switch systests (#813)

* fix(inkless:test): raise S3 timeouts and avoid the isolated broker in switch systests

Six `InklessClassicToDisklessSwitchTest` cases fail on the nightly run for
two reasons unrelated to the switch itself.

#791 set the S3 client defaults to a 2 s call timeout and a 1 s attempt
timeout. The degraded-network tests throttle every broker NIC, including the
path to MinIO, to 2 Mbit/s with 200 ms latency, so WAL uploads outlast 2 s
and fail with `ApiCallTimeoutException`. The producer retries each failed
produce, so it either never recovers or the consumer reads more records than
were acked. `_create_kafka` now sets the call timeout to 60 s and the attempt
timeout to 30 s. That fixes `test_switch_follower_crash_with_lagged_hw`,
`test_switch_leader_crash` (both variants), `test_switch_leader_restart`, and
`test_switch_rolling_restart`, which have failed since #791 merged.

`test_switch_follower_network_partition` isolates a follower and then runs
`kafka-configs.sh` from `self.nodes[0]`. When that node is the isolated
follower, the admin client can't reach its peers, and the describe that
precedes the alter hits its 30 s limit. `_switch_topic_to_diskless` now takes
a `node`, and both network-partition tests pass one from the reachable side.
`test_switch_leader_network_partition` has the same latent bug, since the
leader can also be `self.nodes[0]`.

## Test plan

Run the Inkless System Tests workflow on this branch and check that the six
cases pass. `test_switched_topic_urp_clears_after_replica_recovery` still
fails: that failure is the stranded-follower bug fixed by #760.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix comment formatting in inkless_topic_switch_test.py

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

… switch systests (#813)

* fix(inkless:test): raise S3 timeouts and avoid the isolated broker in switch systests

Six `InklessClassicToDisklessSwitchTest` cases fail on the nightly run for
two reasons unrelated to the switch itself.

#791 set the S3 client defaults to a 2 s call timeout and a 1 s attempt
timeout. The degraded-network tests throttle every broker NIC, including the
path to MinIO, to 2 Mbit/s with 200 ms latency, so WAL uploads outlast 2 s
and fail with `ApiCallTimeoutException`. The producer retries each failed
produce, so it either never recovers or the consumer reads more records than
were acked. `_create_kafka` now sets the call timeout to 60 s and the attempt
timeout to 30 s. That fixes `test_switch_follower_crash_with_lagged_hw`,
`test_switch_leader_crash` (both variants), `test_switch_leader_restart`, and
`test_switch_rolling_restart`, which have failed since #791 merged.

`test_switch_follower_network_partition` isolates a follower and then runs
`kafka-configs.sh` from `self.nodes[0]`. When that node is the isolated
follower, the admin client can't reach its peers, and the describe that
precedes the alter hits its 30 s limit. `_switch_topic_to_diskless` now takes
a `node`, and both network-partition tests pass one from the reachable side.
`test_switch_leader_network_partition` has the same latent bug, since the
leader can also be `self.nodes[0]`.

## Test plan

Run the Inkless System Tests workflow on this branch and check that the six
cases pass. `test_switched_topic_urp_clears_after_replica_recovery` still
fails: that failure is the stranded-follower bug fixed by #760.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix comment formatting in inkless_topic_switch_test.py

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>