Conversation
oda
reviewed
Oct 2, 2025
|
|
||
| 元のメソッド名が`rob`で、円形に並んだ家から盗める最大値を返すことを期待している。 | ||
| この命名が良いかどうかは置いておいて、変えられないものとして考えると、`rob_xxx`といった名前が良いかもしれない。 | ||
| `rob_in_line`だと少し情報が少なすぎるか？ |
There was a problem hiding this comment.
再帰で引数が多いだけだと _helper とか _aux とか後ろにつけて、外から呼ぶことを想定していないことをはっきりさせたりします。今回の場合は、ヘルパーとはいえ、できればコードを読んで何が返ってくるのかが分かる状態にしたいですね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題
213. House Robber II
使用言語
Ruby
次に解く問題
121. Best Time to Buy and Sell Stock