Conversation
tokuhirat
reviewed
Oct 5, 2025
| # @return {Integer} | ||
| def min_sub_array_len(target, nums) | ||
| min_size = Float::INFINITY | ||
| prefix_sum = 0 |
There was a problem hiding this comment.
prefix_sum というよりは subarray_sum かなと感じました。
tokuhirat
reviewed
Oct 5, 2025
| # @param {Integer[]} nums | ||
| # @return {Integer} | ||
| def min_sub_array_len(target, nums) | ||
| min_size = Float::INFINITY |
There was a problem hiding this comment.
初期値は難しいところですが選択肢の一つとして以下のパターンもありだとは思いました。
NOT_FOUND = nums.size + 1
min_size = NOT_FOUND
...
min_size == NOT_FOUND ? 0 : min_size
potrue
reviewed
Oct 5, 2025
| end | ||
| prefix_sum += num | ||
| end | ||
| min_size == Float::INFINITY ? 0 : min_size |
There was a problem hiding this comment.
いいと思います。
別の書き方としては、while trueで二つのポインタを回すような書き方もあると思いました。
Owner
Author
There was a problem hiding this comment.
Rubyらしいというのもありますが、必ずrightは1ずつ動くのでわざわざ自分で+1する必要もないかな、と思いこの書き方しています。
ただ、ポインタを使った方がsliding windowらしいのでそれもアリかもしれません。
コメントありがとうございます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題
209. Minimum Size Subarray Sum
使用言語
Ruby
次に解く問題
https://leetcode.com/problems/permutations/