Conversation
tokuhirat
reviewed
Oct 9, 2025
| # @param {Integer[]} nums | ||
| # @return {Void} Do not return anything, modify nums in-place instead. | ||
| def move_zeroes(nums) | ||
| # leftより左には0以外の値がくる |
There was a problem hiding this comment.
ここのコメントが理解の助けになっていますが、せっかくなら変数名に反映した方がより読みやすくなると思いました。left は num_non_zero_items のような感じで、right は単に確認対象なので i でも良いと思います。
oda
reviewed
Oct 12, 2025
|
|
||
| loop unrollingという言葉を初めて知った。 | ||
|
|
||
| RubyでもArray#fillだと処理を最適化しているようだった。 |
There was a problem hiding this comment.
Ruby の場合はネイティブコードで動くかどうかのほうが速度に大きな影響を与えるでしょう。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題
283. Move Zeroes
使用言語
Ruby
次に解く問題
392. Is Subsequence