Conversation
tokuhirat
reviewed
Oct 9, 2025
| def is_subsequence(s, t) | ||
| pattern = "" | ||
| s.each_char do |c| | ||
| pattern += ".*" + Regexp.escape(c) |
There was a problem hiding this comment.
pattern << ".*" + Regexp.escape(c) の方が自然でしょうか？
potrue
reviewed
Oct 10, 2025
| def is_subsequence(s, t) | ||
| lcs_last_index = 0 | ||
| t.each_char { |char| lcs_last_index += 1 if s[lcs_last_index] == char } | ||
| lcs_last_index == s.size |
There was a problem hiding this comment.
lcsはlongest common subsequenceの略でしょうか？
s="abbbbbb", t="bbbbbb"みたいなときにa以降に進まないので、厳密には正しくない気がします。
checking_indexとかの方が自然ではないでしょうか。
ロジックはとても読みやすいです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題
392. Is Subsequence
使用言語
Ruby
次に解く問題
31. Next Permutation