Repository navigation
feat(cloudflare): run vite dev servers in child processes - #1076
Merged
Merged
Conversation
Contributor
|
Install the packages built from this commit: alchemy bun add alchemy@https://pkg.ing/alchemy/94df145@alchemy.run/better-auth bun add @alchemy.run/better-auth@https://pkg.ing/@alchemy.run/better-auth/94df145@alchemy.run/pr-package bun add @alchemy.run/pr-package@https://pkg.ing/@alchemy.run/pr-package/94df145 |
sam-goodwin
reviewed
Aug 4, 2026
Comment on lines
+100
to
+101
| Effect.provide(RpcServerEnvironment.fromEnv()), | ||
| Effect.provide(PlatformServices), |
Contributor
There was a problem hiding this comment.
Never use two susbsequent Effect.provide.
Always Effect.provide(RpcServerEnvironment.fromEnv().pipe(Layer.provideMerge(PlatformService)))
If RpcServerEnvironment doe not depend on PlatformService, then just do Effect.provide([RpcServerEnvironment.fromEnv(), PlatformService])
sam-goodwin
reviewed
Aug 4, 2026
Comment on lines
+89
to
+93
| yield* Effect.sync(() => { | ||
| process.stdout.write( | ||
| `${VITE_CHILD_READY_PREFIX}${url}${VITE_CHILD_READY_SUFFIX}\n`, | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could this be:
yield* Console.log(`${VITE_CHILD_READY_PREFIX}${url}${VITE_CHILD_READY_SUFFIX}`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run vite server in child process to make sure everything that relies on
process.cwd()gets correct cwd, also capture logs from processes and add[worker] |prefix to logsfixes #1014
fixes #1019
vite side bug fix for
server.portvitejs/vite#23158