Docker support#249
Draft
AmozPay wants to merge 351 commits into
Draft
Conversation
Warning: Concurrent access to the same partition is not prevented
This should solve issues regarding concurrent access to the same partition
This prevents conflicts when running other software on the host.
…an their timeout (#63) This refactors how VMs are managed to isolate the timeout and update logic.
Due to a change in GitHub Actions
Changed to make a single command working for both Linux/macOs
This would have been the source of many duplicate asyncio tasks.
The custom type did not bring any value to the codebase.
Mutating the object being iterated caused inconsistency when iterating over subscribers.
The scheduling of persistent VMs requires external services to fetch the available system resources of the host. Solution: Add a new HTTP endpoint on `/about/usage/system` that exposes system resources and system properties of the host machine.
The traceback for these exceptions did not appear anywhere. Solution: Introduce a new option that allows developers and operators to enable asyncio debug mode. Add helpers to run coroutines in tasks with exception catching and logging and helps with spotting errors in coroutines. Fixup
Clean-up multiple warnings without affecting the behaviour.
Feature: VMs could not be persisted The supervisor only supported on request execution of virtual machines. This add support for an external scheduler to send a list of VMs that should be started and persisted. A temporary simple HTTP authentication method is used to authenticate the scheduler, this is planned to move to P2P messages from Core Channel Nodes.
We still support Ubuntu 20.04 that ships with Python 3.8. Solution: Use a different typing annotation depending on the version of Python, making it easier to ditch the simpler annotation when Python 3.8 goes out of support.
Previously, 172.0.0.0/8 range was hardcoded to be used as the pool for which to assign IP addresses out of. As this was in violation of RFC1918, this needed to change. As this meant reworking the code anyway, it was changed so the range is configurable.
Member
|
Can you rebase this branch on the latest master ? |
The custom type did not bring any value to the codebase.
d4985c9 to
b916cbe
Compare
ba89f63 to
a7227e9
Compare
hoh
reviewed
Feb 3, 2023
|
|
||
| /usr/sbin/dockerd 2>&1 | tee /log_docker.txt & | ||
|
|
||
| log "INIT 0 DONE2" |
Member
There was a problem hiding this comment.
What about a comment about Dockerd being started ?
| -v "$(pwd)/firecracker:/opt/aleph-vm/firecracker:ro" \ | ||
| --device /dev/kvm \ | ||
| -p 4020:4020 \ | ||
| alephim/vm-supervisor-dev $@ |
Member
There was a problem hiding this comment.
Can we merge this in the main script or make it explicit that this is for Docker ?
|
|
||
| WORKDIR /opt/aleph-vm | ||
|
|
||
| CMD "bash" No newline at end of file |
Member
There was a problem hiding this comment.
What differs from the main Dockerfile ?
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| docker image ls | |||
| docker run --rm -p 8080:8080 amozpay/hello_node No newline at end of file | |||
| fi | ||
|
|
||
| echo DOCKER_COMMAND=$DOCKER_COMMAND | ||
|
|
| return Path(settings.FAKE_DATA_VOLUME) | ||
| for volume_bind in str(settings.FAKE_DATA_VOLUME).split(","): | ||
| if volume.mount == volume_bind.split(":")[1]: | ||
| return volume_bind.split(":")[0] |
Member
There was a problem hiding this comment.
What is this change for ? Does it require a comment and a specific commit ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.