You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for submitting this PR and investigating the CID interoperability issue!
Could you please open an issue first describing the observed problem and the relevant RFC requirement? The current change marks the peer’s handshake SCID as original, excluding it from active_connection_id_limit. This conflicts with [RFC 9000 §18.2](https://www.rfc-editor.org/rfc/rfc9000.html#section-18.2), which requires the handshake CID to count toward the limit.
If the goal is only to support peers providing more than eight CIDs, please rebase on main, preserve the existing CID-accounting logic, and change only the limit. The unrelated xqc_conn_try_add_new_conn_id() behavior change need to be removed unless separately justified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanism
<RFC/draft section, or Not applicable>Validation Cases
<case ID>—<concise happy-path or abnormal-path behavior>CONTRIBUTING.md
<Passed / Pending / Not passed><Complete / Incomplete — concise failed cases><Complete / Pending / Failed — concise incomplete checks>