Skip to content

Fix CID handling for single-path H3 clients - #910

Open
taibin wants to merge 1 commit into
alibaba:mainfrom
taibin:asternet-v1.9.4-h3-cid-fix
Open

taibin wants to merge 1 commit into
alibaba:mainfrom
taibin:asternet-v1.9.4-h3-cid-fix

Conversation

@taibin

@taibin taibin commented Aug 21, 2026

Copy link
Copy Markdown

Mechanism

  • RFC or draft: <RFC/draft section, or Not applicable>

Validation Cases

  • <case ID><concise happy-path or abnormal-path behavior>

CONTRIBUTING.md

  • Overall: <Passed / Pending / Not passed>
  • Local regression: <Complete / Incomplete — concise failed cases>
  • CI: <Complete / Pending / Failed — concise incomplete checks>

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Yanmei-Liu

Copy link
Copy Markdown
Collaborator

Thank you for submitting this PR and investigating the CID interoperability issue!

Could you please open an issue first describing the observed problem and the relevant RFC requirement? The current change marks the peer’s handshake SCID as original, excluding it from active_connection_id_limit. This conflicts with [RFC 9000 §18.2](https://www.rfc-editor.org/rfc/rfc9000.html#section-18.2), which requires the handshake CID to count toward the limit.

If the goal is only to support peers providing more than eight CIDs, please rebase on main, preserve the existing CID-accounting logic, and change only the limit. The unrelated xqc_conn_try_add_new_conn_id() behavior change need to be removed unless separately justified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants