[WIP] Fix #571: Reject server Initials with nonzero token length - #948
Open
Yanmei-Liu wants to merge 3 commits into
Open
Yanmei-Liu wants to merge 3 commits into
Yanmei-Liu wants to merge 3 commits into
Conversation
Yanmei-Liu
marked this pull request as ready for review
September 10, 2026 11:09
Yanmei-Liu
force-pushed
the
fix/initial-token-length
branch
from
September 10, 2026 11:39
cd25957 to
46414a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanism
Clients discard server Initial packets with nonzero Token Length before decryption, using the existing invalid-packet error path. The production change is limited to the client check in the Initial parser.
Fixes: #571
Validation Cases
CONTRIBUTING.md
The existing server Retry-token echo and datagram-wide handling of parse errors remain outside this fix; Retry interoperability and coalesced-tail preservation are not claimed.