Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #480.
The pipeline's periodic metric display can show nonzero recent throughput forever after work stops: old samples are removed only when new metrics arrive. Expire the sliding window when rendering it as well, sharing the eviction logic with
add_metrics(). Lifetime totals remain unchanged.Two deterministic clock regressions reproduce full and partial expiry without new samples; both fail on the base and pass after the fix. Updated the Unreleased changelog.
Validation:
pytest tests/test_metrics.py -q(2 passed), Black and isort checks passed. Ruff reports 10 pre-existing deprecated typing-import/annotation findings in metrics.py; none comes from the change. Mypy reports an existing summary-dictionary assignment error, reproduced against the unmodified base file. No model downloads, paid calls, or full OCR integration tests were run; the change and tests use the standard library in a dedicated Python 3.12 environment.Searched existing open/closed issues and PRs for metrics, window, and throughput before implementing.