Skip to content

fix: Validate injection for old Prestashop version - #680

Merged
Benjamin-Freoua-Alma merged 1 commit into
developfrom
fix/ecom-2626-merchant-has-an-issue-with-the-module
Apr 7, 2025
Merged

Benjamin-Freoua-Alma merged 1 commit into
developfrom
fix/ecom-2626-merchant-has-an-issue-with-the-module

Conversation

@Benjamin-Freoua-Alma

Copy link
Copy Markdown
Member

Reason for change

Linear task

Code changes

Inject Validate without use but add \ for validate with old Prestashop version

How to test

As a reviewer, you are encouraged to test the PR locally.

Add to cart in old prestashop version < 1.7

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Apr 7, 2025
@Benjamin-Freoua-Alma
Benjamin-Freoua-Alma requested a review from a team as a code owner April 7, 2025 09:11
@github-actions github-actions Bot added the type: bugfix Bug fix label Apr 7, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 7, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma
Benjamin-Freoua-Alma merged commit 003e664 into develop Apr 7, 2025
@Benjamin-Freoua-Alma
Benjamin-Freoua-Alma deleted the fix/ecom-2626-merchant-has-an-issue-with-the-module branch April 7, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants