Add benchmark summary chart - #16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2f6801890
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| f'<rect x="{x}" y="{y}" width="{width}" height="{height}" rx="{rx}" ' | ||
| f'fill="{fill}" stroke="{stroke}"{dash_attr}{opacity_attr} />' |
There was a problem hiding this comment.
Serialize SVG numbers with fixed precision
svg_rect writes raw Python float representations directly into SVG attributes, which makes regeneration non-deterministic across Python versions/environments (in this repo, python3 benchmarks/plot_summary_svg.py on Python 3.10 rewrites multiple committed lines by tiny rounding deltas even when benchmark data is unchanged). That breaks the documented regen workflow by producing spurious diffs and unnecessary churn; formatting numeric fields to a fixed precision before serialization avoids this.
Useful? React with 👍 / 👎.
Summary
Validation
python3 benchmarks/plot_summary_svg.py