feat(Water Body Local Organization): add read perms for members by barredterra · Pull Request #338 · alyf-de/landa

barredterra · 2026-07-03T14:40:58Z

Summary

This PR makes it visible on Water Body which local organization is responsible for maintaining a water body, without exposing members or contact data.

The previous permission-based approach was reverted because it had an unwanted side effect: water body managers from one organization could potentially see contacts from another organization. Instead, Water Body now loads and renders only the responsible organization name and optional Note.

Changes

Shows responsible local organizations directly on Water Body.
Adds the optional Note field to document maintained sections or other responsibility details.
Loads only the organization name and note needed for display.
Reverts broad member read permissions on Water Body Management Local Organization to avoid exposing contact data across organizations.

Test Plan

Verify that a member can see the responsible organization name on a water body.
Verify that a member can see responsible organizations outside their own organization.
Verify that a member can see the optional note when maintained sections are documented.
Verify that members cannot see contacts or member details from other organizations.
Verify that regional users can maintain the optional note.

- viewing contacts is not allowed (elevated docperm) - not restricted to own organization (ignore_user_permissions)

greptile-apps · 2026-07-03T14:43:22Z

Confidence Score: 4/5

The JS rendering and new note field are correct, but the onload query will raise a permission error for LANDA Members and should be fixed before merging.

The frappe.get_all call in get_water_body_management_local_organizations runs without ignore_permissions=True. LANDA Member is not listed in the Water Body Management Local Organization doctype permissions, so the query will raise frappe.PermissionError when any member opens a Water Body form, preventing the document from loading at all. This directly breaks the feature for the intended audience.

landa/water_body_management/doctype/water_body/water_body.py — the get_water_body_management_local_organizations method needs ignore_permissions=True on its frappe.get_all call.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Member as LANDA Member (browser)
    participant WB as Water Body (server onload)
    participant DB as Database (Water Body Mgmt Local Org)
    participant JS as water_body.js (client)

    Member->>WB: Open Water Body form
    WB->>DB: "frappe.get_all(Water Body Management Local Organization, filters={water_body, disabled=0}, fields=[organization, organization_name, note])"
    DB-->>WB: "[{organization, organization_name, note}, ...]"
    WB-->>Member: doc.__onload.water_body_management_local_organizations
    Member->>JS: refresh → render_water_body_management_local_organizations
    JS->>JS: Read orgs from frm.doc.__onload
    JS->>Member: Render HTML grid (org name + note, XSS-escaped)

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Member as LANDA Member (browser)
    participant WB as Water Body (server onload)
    participant DB as Database (Water Body Mgmt Local Org)
    participant JS as water_body.js (client)

    Member->>WB: Open Water Body form
    WB->>DB: "frappe.get_all(Water Body Management Local Organization, filters={water_body, disabled=0}, fields=[organization, organization_name, note])"
    DB-->>WB: "[{organization, organization_name, note}, ...]"
    WB-->>Member: doc.__onload.water_body_management_local_organizations
    Member->>JS: refresh → render_water_body_management_local_organizations
    JS->>JS: Read orgs from frm.doc.__onload
    JS->>Member: Render HTML grid (org name + note, XSS-escaped)

_{Reviews (4): Last reviewed commit: "fix: null guard on onload" | Re-trigger Greptile}

barredterra · 2026-07-03T14:58:55Z

Unerwünschter Nebeneffekt: Gewässerbetreuung des einen Vereins könnte nun Kontakte des anderen Vereins sehen.

This reverts commit dbdc903.

…ations

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

barredterra · 2026-10-05T16:35:07Z

🎉 This PR is included in version 15.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

barredterra added 2 commits July 3, 2026 16:23

feat(Water Body Management Local Organization): add optional Note field

eadb2b3

feat(Water Body Local Organization): add read perms for members

dbdc903

- viewing contacts is not allowed (elevated docperm) - not restricted to own organization (ignore_user_permissions)

barredterra changed the title ~~lan 888~~ feat(Water Body Local Organization): add read perms for members Jul 3, 2026

greptile-apps Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread ...ctype/water_body_management_local_organization/water_body_management_local_organization.json Outdated

barredterra closed this Jul 3, 2026

Revert "feat(Water Body Local Organization): add read perms for members"

defc284

This reverts commit dbdc903.

barredterra reopened this Jul 3, 2026

feat(Water Body): load and render Water Body Management Local Organiz…

c862faa

…ations

greptile-apps Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread landa/water_body_management/doctype/water_body/water_body.js Outdated

fix: null guard on onload

110bc9b

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

greptile-apps Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread landa/water_body_management/doctype/water_body/water_body.py

barredterra merged commit 19a816a into alyf-de:version-15-hotfix Jul 3, 2026
9 checks passed

barredterra deleted the lan-888 branch July 3, 2026 15:48

barredterra added the released on @version-15 label Oct 5, 2026

Navigation Menu

Repository navigation

feat(Water Body Local Organization): add read perms for members - #338

feat(Water Body Local Organization): add read perms for members#338
barredterra merged 5 commits into
alyf-de:version-15-hotfixfrom
barredterra:lan-888

barredterra commented Jul 3, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 3, 2026 •

edited

Loading

Sequence Diagram

Uh oh!

Uh oh!

barredterra commented Jul 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barredterra commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

barredterra commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Plan

Uh oh!

greptile-apps Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Sequence Diagram

Uh oh!

Uh oh!

barredterra commented Jul 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barredterra commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

barredterra commented Jul 3, 2026 •

edited

Loading

greptile-apps Bot commented Jul 3, 2026 •

edited

Loading