Repository navigation
fix(Yearly Fishing Permit Gewaesserfonds): set organization in bulk create - #359
Merged
Merged
Conversation
…reate The create permission check runs before fetch_from fills the organization, so users with a strict User Permission on Organization could not create permits.
Contributor
|
Member
Author
|
🎉 This PR is included in version 15.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk creation of Yearly Fishing Permit Gewaesserfonds did not set
organizationbefore insert. Frappe checks the create permission beforefetch_fromfills the field. Because of this, the check failed for users with a strict User Permission on Organization.This change loads the organization of all selected members in one query and sets it on each permit before insert.