Gh pages secrets redaction - #11
Merged
Merged
Conversation
-fix missing colon in try/except -add set_passphrase doc -make sample added user not special Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Add doc for: -add_field_data -overwrite_field_data -add_more_secrets Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Change Add More Secrets to Add Additional Secret Traits as coded -Change input to list rather than a dictionary Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
reviewed
Aug 21, 2023
lcarcaramo
reviewed
Aug 21, 2023
lcarcaramo
reviewed
Aug 21, 2023
lcarcaramo
reviewed
Aug 21, 2023
-Fix typos -Reword some doc on Add Additional Secret Traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Make changes to custom field data functions based on recent code changes -Change code samples to use full trait dictionary Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Change 'overwrite_segment_traits' to 'overwrite_existing_segment_traits' Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Convert "Overwrite Existing Segment Traits" to "Replace Existing Segment Traits" Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
…f into gh-pages-secrets-redaction
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
… download & installation. Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
lcarcaramo
approved these changes
Sep 12, 2023
lcarcaramo
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: #6
💻 What does this address?
Adds documentation to accompany PR #9 . Additionally touches up documentation with some typo fixes and references to previously undocumented functionality.