Clean Custom Field Functions#14
Merged
Merged
Conversation
Change all calls to SMO to include option 8 for secrets redaction. Drop methods that contain potentially sensitive information as soon as they are no longer necessary. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Check to ensure new redaction eliminates password and password phrase information within the result Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-changes the way secrets are redacted on input -no longer stores copy of secrets for replacement Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-customers can add new secrets to redact -cannot overwrite existing secrets for security Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-add set_passphrase settr to UserAdmin -add unit testing for this feature Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-add functionality to redact secrets beyond default -cannot change defaults as this is security concern, once something is added, a new instance would be necessary - unit test for this must be run after all other user tests as it redacts UID's and this cannot be reversed for the life of the SecurityAdmin object Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-minor typo fixes and name changes -convert options parameter to precheck keyword. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Names, and formatting changes -Addition of docstrings -Tweak usability and error handling within some functions Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-docstring changes -convert _secret_traits to __secret_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Move valid_segment_traits to function group constructors -Move secret_traits to main class constructor -Move unit testing for additional secret redaction back into logger tests for user_admin -add input cleanup to generate request only path and remove cleanup on entry to functions -docstring updates and minor code improvements Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-adjust docstrings -change file names -add new unit tests to confirm only secrets are redacted Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-black formatter adjusting formatting Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Fix docstrings fix typos update __clear_state function Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Fix docstrings -Clean up positional/keyword arguments -Clean unit testing and code bits Signed-off-by: Elijah Swift <elijah.swift@ibm.com> Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Re-introduce assertNotIn and assertIn unit testing Add simplified unit testing for "simple" password redaction Fix docstrings and minor errors Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-clean type hints -added assertnotin for additional secrets unit testing Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Chance instances of add_field_data to update_existing_segment_traits -Change instances of overwrite_field_data to overwrite_segment_traits -Change __add_field_data to __add_additional_valid_segment_traits -Change __overwrite_field_data to __overwrite_valid_segment_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Secrets redaction
lcarcaramo
reviewed
Aug 30, 2023
-Change overwrite_segment_traits to overwrite_existing_segment_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Chance instances of add_field_data to update_existing_segment_traits -Change instances of overwrite_field_data to overwrite_segment_traits -Change __add_field_data to __add_additional_valid_segment_traits -Change __overwrite_field_data to __overwrite_valid_segment_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Change overwrite_segment_traits to overwrite_existing_segment_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Condense Testing to 1 for Overwrite Valid Segment Traits and 1 for Add Additional Valid Segment Traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
reviewed
Sep 6, 2023
Change add_additional_valid_segment_traits to update_valid_segment traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
reviewed
Sep 6, 2023
-Overwrite function is now "Replace" -"Add additional" is completely translated to update Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
reviewed
Sep 7, 2023
lcarcaramo
reviewed
Sep 7, 2023
-Update docstrings associated with Customized Segment traits -Fix issue where Add_Additional_Secret_Traits was renamed Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Update docstrings Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
approved these changes
Sep 8, 2023
EmmasBox
pushed a commit
to EmmasBox/pyracf
that referenced
this pull request
May 18, 2025
…-connection Add Group and Group Connection documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Chance instances of
add_field_datatoupdate_existing_segment_traits-Change instances of
overwrite_field_datatooverwrite_segment_traits-Change
__add_field_datato__add_additional_valid_segment_traits-Change
__overwrite_field_datato__overwrite_valid_segment_traitspart of cleanup prior to release of pyracf 1.02a