Resource profile sub functions - #29
Merged
Merged
Conversation
Add Drafted sub-functions to Resource Admin for testing. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Fix bug in Resource and Dataset Add/Alter errors that would allow generic profiles to cause issues -Test CFDEF MXLENGTH in case of typo in doc -Drive GenerateRequestOnly to faster output in Alter functions. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Translate null characters to blanks when not preceded by ">" to prevent premature string termination. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Made it codepage agnostic: Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Mapping Extract fucntions Cleaning up c code Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Add Unit Testing for Sub Functions Further optimize c code
lcarcaramo
reviewed
Nov 2, 2023
lcarcaramo
reviewed
Nov 2, 2023
lcarcaramo
reviewed
Nov 2, 2023
lcarcaramo
reviewed
Nov 2, 2023
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
ElijahSwiftIBM
force-pushed
the
resource-profile-sub-functions
branch
from
November 2, 2023 15:57
87551eb to
c53fdcc
Compare
lcarcaramo
reviewed
Nov 2, 2023
lcarcaramo
reviewed
Nov 2, 2023
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
lcarcaramo
approved these changes
Nov 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: #10
💻 What does this address?
This adds 6 key sub functions to general resource profile administration:
This also fixes key bugs uncovered in the new Add/Alter functions in general resource and dataset profiles as well as a workaround for unintended functionality of the IRRSMO00 callable service
📟 Implementation Details
The sub-functions were built like the getters/setters of resource administration focusing on specific classes and segments.
📋 Is there a test case?
For this, unit tests were developed to verify correct generation of new requests and correct extraction of specified segment information from the proper profiles.
New Unit tests were also built to deal with the bug in Add and Alter operation errors.
Either include the path to the test case file, or details on a manual test