Skip to content

Bug/filter out tso messages on success - #31

Merged
ElijahSwiftIBM merged 4 commits into
devfrom
bug/filter_out_tso_messages_on_success
Nov 2, 2023
Merged

Bug/filter out tso messages on success#31
ElijahSwiftIBM merged 4 commits into
devfrom
bug/filter_out_tso_messages_on_success

Conversation

@lcarcaramo

Copy link
Copy Markdown
Member

💡 Issue Reference

Issue: #30

💻 What does this address?

Resolves #30 and removes extraneous code from the test_alter_user_request_debug_log_password_xml_tags_not_redacted_on_error() test case in test_user_debug_logging.py.

📟 Implementation Details

  • Extra messages in profile extract data or more specifically data returned by the listdata operation are removed. This is implemented in common/security_result.py so that this bug is resolved for all function groups that use the listdata operation.
  • Extraneous code has been removed from test_alter_user_request_debug_log_password_xml_tags_not_redacted_on_error().

📋 Is there a test case?

See results of Unit Tests in Github Actions.

Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
@lcarcaramo lcarcaramo added the bug Something isn't working label Nov 2, 2023
@lcarcaramo lcarcaramo added this to the Beta 1.0b1 milestone Nov 2, 2023

@ElijahSwiftIBM ElijahSwiftIBM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ElijahSwiftIBM
ElijahSwiftIBM merged commit 05903d2 into dev Nov 2, 2023
@ElijahSwiftIBM
ElijahSwiftIBM deleted the bug/filter_out_tso_messages_on_success branch November 2, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants