Release 1.0b3#58
Merged
Merged
Conversation
-Standardize SecurityRequestError Structure, merging IRRSMO00 Errors and that of RACF Errors with the smae internal structure in the result dictionary -Add an install script that defines IRR.IRRSMO00.PRECHECK with UACC of none and/or checks if the profile exists and the current user's access -Added NullResponseError -Added Unit Testing for Install script and null response error Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Add parameters to irrsmo00.c for userid and userid_len -Add code in irrsmo00 that can process a userid and pass it and length to c code -Add methods to security admin object that allow for changing executing userID -Add ImproperUSerIDError to enforce userid changes to theoretically valid ids Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Make changes to be compatible with 3.10 typing library Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Change type of default userid parm passed to irrsmo00. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Also allow for run as userid to be specified in object creation Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Fold Surrogat error (run as userid attempted with no access defined) that yields no response into Null Response Error -Use surfaced return and reason codes from IRRSMO00 to differentiate null response errors -Add get_user_access to resource admin -Add unit testing for all of it -move custom traits testing under common folder Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Update type hints and error message to bring in line with doc Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Change UserID to UserId refactor call_racf change error text strings Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Changing error text and formatting Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Refactor IRRSMO00 Security Request Errors under Null Response Error Change Security Request Error to Security Response Error Change Null Response Error to Security Request Error Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Get current user on OS\390 systems to add to result dictionary -On non-OS\390 systems use placeholder "testuser" -add this value into all unit tests Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Name and formatting changes -Add userid to result dictionary no matter what Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Docstring Changes/Formatting updates -Move common test xml,json and log files into common directory -Attempted fix of build failures Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Naming changes text updates Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Unit testing added for surfacing SecurityRequestErrors from initial extract in Add operations if the error is not "the resource does not yet exist" Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Change comment string for DownstreamFatalError Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Function testing revealed a couple of bugs in how the response value from the c code was parsed in python. This resolves that issue. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
pass pointers to return codes rather than values. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Add Function Test for DownstreamFatalError (Null Response checking is based off something unit testing does not fully check) Add real error messages to tests in Add operations that surface error from initial extract. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Changed docstring for DownstreamFatalError Update version number to 1.0b3 for next release Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Change type hints for get_running_userid to Union[str, None] Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Run as UserID and Error handling changes
ElijahSwiftIBM
approved these changes
Jan 4, 2024
ElijahSwiftIBM
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, passed all unit and function testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
https://github.com/ambitus/pyracf/milestone/4
💻 What does this address?
Refer to GitHub Milestone.
📟 Implementation Details
Refer to GitHub Milestone.
📋 Is there a test case?
Refer to GitHub Milestone.