Update pyproject.toml - #8
Conversation
change setup.cfg and setup.py to pyproject.toml pyproject.toml can still work with a minimal setup.py for dynamic elements like the pyobject we are building, but the pyproject toml is useful Update pyproject.toml Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
|
Linters, code formatters, and other development dependencies don't appear to pulling configuration from pyproject.toml. |
|
It also looks like an update or two might need to be made to |
Only identified one reference. Changed to: |
to my knowledge, pylint and isort are getting their config correctly. flake8 does not support pyproject.toml. I have added a .flake8 file containing the following for now. This can be changed to a setup.cfg if preferred. |
-add .flake8 file -move items within main in setup.py -change CONTRIBUTING.md to reference pyproject.toml Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-flake8 does not support pyproject.toml, we now configure via .flake8 file, removing references to flake8 in toml file. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Add newlines for consistent formatting -isort change single quotes to double-quotes in setup.py Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Remove empty newlines -Update docstring -Remove Extra Link Args Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
784d911 to
81d755f
Compare
-Fix docstrings Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
change setup.cfg and setup.py to pyproject.toml
pyproject.toml can still work with a minimal setup.py for dynamic elements like the pyobject we are building, but the pyproject toml is useful
Update pyproject.toml
💡 Issue Reference
Issue: #3
💻 What does this address?
Standards are shifting from setup.py to pyproject.toml for static attributes
📟 Implementation Details
Most items from the setup.py and setup.cfg are moved to pyproject.toml with the exception of dynamic extensions which are still built as part of setup.py
📋 Is there a test case?
Test case suite does not test build, but code was built from pip install through the repo using ssh and a manually built wheel and functionality is still present.
Either include the path to the test case file, or details on a manual test