Repository navigation
fix(explorer): retry a no_root listing until the pane reports its cwd - #452
Merged
amirlehmam merged 1 commit intoNov 13, 2026
Merged
Conversation
A pane restored after a wmux restart reports its cwd only when its shell next speaks, and nothing re-fetched when that report landed, so the explorer kept showing 'has not reported a working directory' until Refresh was pressed. Ask again every 3s while that exact error is showing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The explorer shows "This pane has not reported a working directory yet" when main has no cwd for the pane (
no_root). That state is not permanent: a pane restored after a wmux restart (a devcontainer shell, for example) reports its cwd only when its shell next speaks, and a pane started asbash -c <cmd>may not report again for a long time. Nothing re-fetches when the report finally lands, so the error stays on screen until the user presses Refresh.Change
In
ExplorerPanel.tsx, while the panel is showing exactlyno_rootand has a surface and root, it asks again every 3s (NO_ROOT_RETRY_MS). A counter re-arms the timer, because a retry answered withno_rootagain sets the sameerrorand would not re-run the effect on its own. Any other outcome changes or clearserrorand the loop stops; unmounting clears the timer.Testing
tscandeslintare clean. The file stays LF (22 lines added, none removed).Cost
One
explorer:list-dirIPC call every 3s per panel while the error is showing, and nothing otherwise.🤖 Generated with Claude Code