Repository navigation
feat(panes): lock a pane against spawned agents and moved tabs - #454
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Add a "Lock pane" / "Unlock pane" item to the tab context menu and a padlock button in a locked pane's tab bar (aria-label "Unlock pane"), wired to the setPaneLocked store action. New surfaceTab.lockPane, unlockPane and lockedTooltip strings in all 18 locales. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d stub Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
amirlehmam
added a commit
that referenced
this pull request
Nov 15, 2026
…of the global context stub Follow-up to #454. handleToggleLock wrote to the active workspace while the lock state was read from the pane's own workspace. The skill description and the context stub written into ~/.claude/CLAUDE.md go back to their previous text: the lock paragraph stays in claude-instructions.md, which agents read on demand, and a spawn into a locked pane already fails with a clear message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a pane lock. A locked pane cannot receive a spawned agent and cannot receive a moved or dragged tab. Resizing it stays allowed, and so do the
+button and closing the pane or its tabs. The lock is saved insession.jsonand restored. It is switched from the tab-bar context menu, and a padlock shows on a locked pane.The behaviour was specified up front (scope, decisions and acceptance criteria) and every task was reviewed by a separate reviewer who ran the tests and mutated the code.
Decisions worth knowing:
locked?: trueon the split-tree leaf. Unlocking removes the key, so an unlocked tree serializes exactly as before.layout gridrefuses a workspace that contains a locked pane;layout agentskeeps working and leaves the anchor's lock alone.wmux new-surfaceandwmux markdownwithout--pane, side-panel "open in new tab") skip locked panes (D6).Tasks
Every task was written by a fresh coder and checked by a fresh code-reviewer who ran the tests and mutated the code to prove each acceptance criterion's test fails when the behaviour breaks. Two reviews sent work back (T2 stale split preview, T7 missing three-pane test, T9 double dialog on re-activation); all were fixed in new commits.
layout gridrefusal,pane listlock flagresources/cli/wmux.jsnew-surfaceskips locked paneswmux markdownclause mention locksTesting
npx vitest runon the merged branch: 3 files fail, 416 pass (6781 tests pass, 10 fail). The 3 files aredictation-shortcut,pty-managerandshortcut-recorder. They fail the same way on the base commit and do not touch this change. (Earlier runs showed 12 failing files on the base; 9 of them only failed becausekatex,mermaidandqrcode-generatorwere missing fromnode_modules.)tsc(node and renderer) andeslinton the changed files are clean.npm run dev: lock and unlock from the tab menu, padlock, drag onto the middle (not-allowed cursor, no preview, also when moving from the edge to the middle), edge split still works, resize still works, lock survives a restart.Review notes
surfaceTab.lockPane,surfaceTab.unlockPane,surfaceTab.lockedTooltip) andpalette.allPanesLockedin hi, tr, ko, sv, cs, zh-TW and ja were written by a model and need a native speaker's look.Pane <id> is lockedmessage string could be a shared helper;layout grid --count 1on a locked workspace returns success before the lock check (it changes nothing).🤖 Generated with Claude Code