Skip to content

Bring the window forward when notification toast is clicked - #457

Merged
amirlehmam merged 1 commit into
amirlehmam:masterfrom
strayge:fix/notification-window-focus-pr
Nov 15, 2026
Merged

amirlehmam merged 1 commit into
amirlehmam:masterfrom
strayge:fix/notification-window-focus-pr

Conversation

@strayge

@strayge strayge commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Problem

Clicking a wmux toast notification did not reliably bring wmux forward.
A minimized window stayed minimized, and a window behind other apps could stay behind them.

The click could also sometimes do nothing at all: wmux kept no reference to the Electron Notification, so it could be garbage-collected while the toast was still on screen, taking its click handler with it.

Changes

  • On toast click, restore a minimized window and move it to the top before focusing it and selecting the surface.
  • Keep each shown toast in NotificationManager until it is clicked, closed or fails, or until show() throws.

Testing

  • Full suite: 6,708 passed, 10 skipped (416 test files passed, 2 skipped).
  • npm run typecheck passed.
  • git diff --check passed.

@strayge strayge changed the title Bring the window forward when a toast is clicked Bring the window forward when a notification toast is clicked Nov 14, 2026
@strayge strayge changed the title Bring the window forward when a notification toast is clicked Bring the window forward when notification toast is clicked Nov 14, 2026
@amirlehmam
amirlehmam merged commit e67e7be into amirlehmam:master Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants